Prefetch syncs to redis
Changes:
- reloadCacheEntry removes EDNS0 records from response
- reloadCacheEntry publishes its result to Redis
Closes #1422
Related #1420
Codecov Report
Attention: Patch coverage is 62.98077% with 77 lines in your changes missing coverage. Please review.
Project coverage is 92.92%. Comparing base (
fe84ab8) to head (7b2fcc2). Report is 147 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1446 +/- ##
==========================================
- Coverage 93.88% 92.92% -0.97%
==========================================
Files 78 79 +1
Lines 6361 5030 -1331
==========================================
- Hits 5972 4674 -1298
+ Misses 300 251 -49
- Partials 89 105 +16
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ThinkChaos I started refactoring the whole caching_resolver. May take a bit more time but I think there's some enhancement potential regarding code duplication and inconsistent behavior.
Thanks for the input. 👍
I'll let you know when I'm done.
@ThinkChaos still needs some tests but may I get your opinion on the current changes? I'm a bit unsure if the direction I took was an advancement? 🤔
I had to checkout the branch locally to browse with my editor cause it is indeed a lot of functions calling combined in a couple different ways so definitely hard to follow!
I had to checkout the branch locally to browse with my editor cause it is indeed a lot of functions calling combined in a couple different ways so definitely hard to follow!
Yeah I know, that's one of the reasons why I was a bit unsure about the direction. 🫣
Good thing I looked deeper into the caches since I found a remaining context.Background() : https://github.com/0xERR0R/blocky/blob/main/cache%2Fexpirationcache%2Fexpiration_cache.go#L129