Virgo icon indicating copy to clipboard operation
Virgo copied to clipboard

GR 3.8/3.9 compatibility

Open 0xCoto opened this issue 4 years ago • 5 comments

I just discovered what has been causing issues for GR 3.8/3.9. Seems like the dev_args and obs_file parameter blocks are set to Type: None, but setting them to String resolves problems.

To-do: Test if Type: String is compatible with GR 3.7 as well, or if only Type: None is the exclusive workaround for the old version, and integrate the fix.

0xCoto avatar Mar 05 '21 20:03 0xCoto

What issue? It's working fine on GnuRadio 3.8.2.0 with dev_args and obs_file types set to None

awasisto avatar Mar 09 '21 16:03 awasisto

Really? That's interesting. I guess the issue only applies to version 3.9 then. Thanks for informing!

0xCoto avatar Mar 09 '21 16:03 0xCoto

Just tested on GnuRadio 3.9.0.0. You're right, it fails to run. Changing dev_args and obs_files types to String works and it still works on 3.8.2.0. So I believe they're safe to change

awasisto avatar Mar 10 '21 14:03 awasisto

Update: I've just tested the modified grc on 3.7.13.4 and it doesn't work. I guess the fix is not backward compatible with 3.7

awasisto avatar Mar 20 '21 18:03 awasisto

Thanks a lot, that's a valuable observation! Since many users appear to still be using GR 3.7 (but an equally large amount has shifted to 3.8/3.9), my plan is to include two new .grc flowcharts in the same directory (one for FTF & one for WOLA), and assign two of them for 3.7 and the other two for 3.8/3.9. Once I find some time to push the fix, Virgo should be GR-3.7/3.8/3.9 compatible. 🙂

0xCoto avatar Mar 20 '21 23:03 0xCoto