videoduplicatefinder icon indicating copy to clipboard operation
videoduplicatefinder copied to clipboard

Docker

Open kozobot opened this issue 1 year ago • 5 comments

Adding a docker build for this project.

The end result is a Docker image that can be used to run VDF in a container and is accessible via a browser based VNC client.

kozobot avatar Oct 18 '22 20:10 kozobot

Is this file only available when people download the code? So as an end user without developing experience I cannot simply download a "docker" ready-to-go release?

0x90d avatar Oct 23 '22 05:10 0x90d

That is correct. The built image would need to be pushed to dockerhub. I'd be happy to do it, but it might be better coming from the maintainer.
It could be possible to setup some git actions/workflow to push this automatically as well.

kozobot avatar Oct 28 '22 13:10 kozobot

Closes #295

MichelZ avatar Nov 14 '22 06:11 MichelZ

[~] # docker pull ghcr.io/0x90d/videoduplicatefinder Using default tag: latest Error response from daemon: Head "https://ghcr.io/v2/0x90d/videoduplicatefinder/ manifests/latest": denied

Is there a better way to do this?

dsrtusr88 avatar Nov 23 '22 20:11 dsrtusr88

it might be better coming from the maintainer.

I have zero experience with dockers at all, so I cannot help with that. And I think docker support requests are coming from end users expecting a "ready to go" release. So ideally a docker PR would take care of all of that, plus its getting reviewed from people who have docker experience.

0x90d avatar Nov 27 '22 00:11 0x90d

@kozobot how do you actually pull this docker image to use?

dsrtusr88 avatar Dec 03 '22 21:12 dsrtusr88

@dsrtusr88 the only way right now is to build it. It would need to be pushed to be pushed to dockerhub for it to be generally accessible.

If this gets approved. I could push this to dockerhub myself. But I can't guarantee that I would keep it up to date.

kozobot avatar Dec 14 '22 18:12 kozobot

If this gets merged, I can submit a PR that will use GitHub Actions to create a docker image under the packages of the repo.

To pull the image then would be something like

docker pull ghcr.io/0x90d/videoduplicatefinder

Gibby avatar Jan 10 '23 16:01 Gibby

@0x90d can this be merged?

dsrtusr88 avatar Jan 22 '23 17:01 dsrtusr88

VDF uses .NET 7 now, so @kozobot would have to update this PR. But there are also some other projects like https://github.com/jlesage/docker-video-duplicate-finder which seem to be more powerful and very well documented.

0x90d avatar Feb 05 '23 05:02 0x90d

Closing this as there is no activity. @kozobot feel free to open an updated PR if you like. For everyone else just looking for docker support I recommend checking out the repo in my post above.

0x90d avatar Mar 05 '23 01:03 0x90d