Notepads icon indicating copy to clipboard operation
Notepads copied to clipboard

Update to WinUI 2.7

Open BobbyESP opened this issue 2 years ago • 17 comments

App style update

PR Type

What kind of change does this PR introduce?

  • Updated most of the components of the app to WinUI 2.7

Bugs known

  • Settings NavigationView doesn't load the first NavigationItem

Captura de pantalla 2021-10-30 182615

  • Some strange errors when opening the app in App.xaml.cs file, line 50 related with AppCenter (never heard about that)

BobbyESP avatar Oct 30 '21 16:10 BobbyESP

The errors in App.xaml.cs: Captura de pantalla 2021-10-30 183705 Captura de pantalla 2021-10-30 183749 Captura de pantalla 2021-10-30 183730

BobbyESP avatar Oct 30 '21 16:10 BobbyESP

Ah yes, forgot to tell that the Navigation Item that doesn't open when you open settings can be opened by clicking on it. Just fails when you open the settings.

BobbyESP avatar Oct 30 '21 17:10 BobbyESP

I will be working on the visual update by EOY. I will wait for WinUI 2.x to get mature before doing so.

0x7c13 avatar Oct 31 '21 00:10 0x7c13

It's ok. If you need some help, tell me. WinUI 3 by the moment isn't avaliable for UWP or it's very unestable, so better wait.

BobbyESP avatar Oct 31 '21 10:10 BobbyESP

Delete all custom style and update UI: image

0x5bfa avatar Dec 25 '21 16:12 0x5bfa

@BobbyESP Hai. how have you seen:)

Settings NavigationView doesn't load the first NavigationItem

FYI, It's a not bug but specification. so, need to load the page in NaviView_Loaded() or Page_Loaded()

Instead, use the IsSelected flag to receive change events on ItemSelected. but this app uses ItemInvoked() this do not trigger selection changing event from IsSelected = true.

https://github.com/JasonStein/Notepads/blob/master/src/Notepads/Views/Settings/SettingsPage.xaml#L18

0x5bfa avatar Mar 05 '22 13:03 0x5bfa

Ohh, i see!

BobbyESP avatar Mar 05 '22 14:03 BobbyESP

I am waiting for WinUI v2.8 stable release before looking into upgrading the UX. Are there any issues you find with v2.8 prerelease?

0x7c13 avatar Mar 14 '22 19:03 0x7c13

ah. I don't have the problem I saw in WinUI prerelease in UI Control, but I found a lot in WerbView2 regardless of whether you are using WebView2.

Also, due to that issue, projects that download WinUI 2.8 prerelease may fail in store submissions. In fact, I came across that error of win cert kit.

It may be a big help, why not use WinUI2.7 stable ver?

0x5bfa avatar Mar 15 '22 03:03 0x5bfa

And when updating to WinUI 2.7 or later, the IsSelect property does not trigger the ItemInvoked event. It still triggers SelectionChanged, so you need to navigate to the initial page when loading the settings page. You will find it during the migration.

0x5bfa avatar Mar 15 '22 03:03 0x5bfa

There are some other UI issues bringing by the v2.7 release, I cannot remmeber the exact but it has been disscussed earlier. The rolling speed of the WinUI 2 and 3 releases are much slower than my expectation:(

0x7c13 avatar Mar 15 '22 05:03 0x7c13

Guys It has been over two years now. When will this UI update take place?

KParthSingh avatar Feb 18 '24 06:02 KParthSingh

https://tenor.com/be8xy.gif

KParthSingh avatar Feb 20 '24 05:02 KParthSingh

The owner hesitates to move to WinUI2.8 or 3.0 because it would bring more WinUI-side issues.

0x5bfa avatar Feb 20 '24 05:02 0x5bfa

Damn.

KParthSingh avatar Feb 20 '24 10:02 KParthSingh

WinUI-side issues

Are these issues are still relevant as for today? WinUI v2.8 stable release came out quite a long time ago.

emvaized avatar Mar 19 '24 06:03 emvaized

I said the same thing to them. lol.

0x5bfa avatar Mar 19 '24 20:03 0x5bfa