Notepads icon indicating copy to clipboard operation
Notepads copied to clipboard

style: improve UserControls design

Open United600 opened this issue 1 year ago • 2 comments

Improves the look and visual states of the DismissButtonStyle (renamed to TransparentButtonStyle) and the respective UserControls that make use of it.

PR Type

  • Other... Please describe:

Find and Replace

  • Improve padding
  • Improve glyphs
  • Improve High Contrast
  • Improve ToggleReplaceModeButton touch target
  • Add ToggleReplaceModeButton animation
  • Add SelectionIndicator animation

https://github.com/0x7c13/Notepads/assets/698155/589ef5b7-f332-421c-b4e5-9f638324352f

GoTo

  • Improve padding
  • Improve glyphs
  • Improve HighContrast

https://github.com/0x7c13/Notepads/assets/698155/5862e643-2610-4b9f-b819-b3111acf68ee

SideBySideDiffViewer

  • Improve brushes
  • Improve DismissButton size

https://github.com/0x7c13/Notepads/assets/698155/be773f7f-8311-4bd9-ae98-7851cf49eb67

Other information

Adds some design attributes and better XAML formatting.

United600 avatar Mar 16 '24 15:03 United600

@United600 I have played around with latest WinUI3/WinAppSdk and decided to adopt the design and app model once its get matured. So far, there are still lots of issues presented(I have spent 30+ hours building an app using WinAppSDK so I know what I am speaking. NativeAOT support is also just realized by most of the parties. Guess we still need to wait for some time before taking any major actions. FYI: Your changes will be obsolete once we move to settings card controls etc when adopting WinUI3.

0x7c13 avatar Nov 11 '24 21:11 0x7c13

That's sad to hear. Personally, I would have opted for WinUI 2 first and stuck with UWP in the meantime. Sure some of the changes here would be obsolete, eg. Expander, however they are applicable to a future migration.

United600 avatar Nov 11 '24 23:11 United600