FluentHub icon indicating copy to clipboard operation
FluentHub copied to clipboard

Bug: App crashes when repository opened in a non-existent application

Open Lamparter opened this issue 1 year ago • 6 comments

🪟 What version of Windows is this issue present?

🪟 Windows 11

🔢 What version of FluentHub are you on?

0.8.60.0 | X64 | DEBUG (This does not affect the error)

📄 Description

App crashes when opening GitHub Desktop/Visual Studio from the repository Clone context menu if the appropriate app is not installed.

🪜 Steps To Reproduce

  1. Navigate to a repo
  2. Press on the Clone button
  3. From the context menu, open the repo in an app you do not have installed (Visual Studio or GitHub Desktop as appropriate)
  4. App crashes.

🤔 Expected behavior

App should check for application install and grey out the button or open a browser with arguments for the URI which would prevent app crash.

⚒️ Did you find any workaround?

No response

📑 Stack Trace

Stack trace is not associated with this error.

📸 Assets

https://github.com/user-attachments/assets/48eedd8d-dbed-4564-9216-4b6ab064f243

As you can see, the app crashes when the user attempts to open the repository with GitHub Desktop which is not installed on the machine.

Lamparter avatar Jul 23 '24 14:07 Lamparter

To fix this I will build a custom website that opens different github clients

Lamparter avatar Aug 27 '24 09:08 Lamparter

Real? Why not just send user to GitHub Desktop download page.

0x5bfa avatar Aug 27 '24 09:08 0x5bfa

Real? Why not just send user to GitHub Desktop download page.

There are other git clients as well such as gitlens, GitGUI and gitkraken

Lamparter avatar Aug 27 '24 10:08 Lamparter

Ok but why do you have to set up a website? I thought we can detect installation of any git clients?

0x5bfa avatar Aug 27 '24 11:08 0x5bfa

Ok but why do you have to set up a website? I thought we can detect installation of any git clients?

We can but it's a project I've been meaning to make anyway lol

Lamparter avatar Aug 27 '24 12:08 Lamparter

Real? Why not just send user to GitHub Desktop download page.

@0x5bfa I'll just try other clients on error and if still fails, show GitHub Desktop download page.

Lamparter avatar Aug 30 '24 06:08 Lamparter