FluentHub icon indicating copy to clipboard operation
FluentHub copied to clipboard

Markdown formatting

Open Lamparter opened this issue 2 years ago • 32 comments

Before you start...

  • [X] Have you checked if a similar feature request has already been reported?

Description

Various changes to make README formatting more fluent:

  1. Text written

(>) with this style

should use InfoBar:

No InfoBar: image InfoBar: image ~ it could have an x button to close it.

  1. Hyperlink button On headers, there is a hyperlink button. However, the icon for this is hidden slightly and looks ugly. image As well as this, the button itself is pretty useless.

Alternative solutions

No response

Relevant Assets

No response

Lamparter avatar Jun 04 '22 16:06 Lamparter

used in the README are HTML and CSS.

0x5bfa avatar Jun 04 '22 16:06 0x5bfa

used in the README are HTML and CSS.

Oh so its just previewed with web and not actually involved with FH?

Lamparter avatar Jun 04 '22 16:06 Lamparter

This CSS has been a problem for some time. But once it was closed because we didn't think we could make something better than the current UI. https://github.com/FluentHub/FluentHub/issues/58

0x5bfa avatar Jun 04 '22 16:06 0x5bfa

Oh so its just previewed with web and not actually involved with FH?

Yes. just borrowed from github-markdown-css

0x5bfa avatar Jun 04 '22 16:06 0x5bfa

Ohh. Can we use custom CSS?

Lamparter avatar Jun 04 '22 16:06 Lamparter

There is the idea of using MarkdownBlock or RichTextBlock, but I feel it should be discussed.

0x5bfa avatar Jun 04 '22 16:06 0x5bfa

Ohh. Can we use custom CSS?\

Of course.

0x5bfa avatar Jun 04 '22 16:06 0x5bfa

https://github.com/FluentHub/FluentHub/tree/main/src/FluentHub/Assets/WebView

0x5bfa avatar Jun 04 '22 16:06 0x5bfa

https://unpkg.com/fluent-svelte/theme.css

Maybe this will work?

Lamparter avatar Jun 04 '22 16:06 Lamparter

should be. this css just declare variables

0x5bfa avatar Jun 04 '22 16:06 0x5bfa

Ok, i need to see the libraty, but this is gonna be hard. Fluent Svelte is like a framework and we need to take a look to how it works

@BobbyESP He has said previously.

0x5bfa avatar Jun 04 '22 16:06 0x5bfa

Ok, i need to see the libraty, but this is gonna be hard. Fluent Svelte is like a framework and we need to take a look to how it works

@BobbyESP He has said previously.

when?

Lamparter avatar Jun 04 '22 16:06 Lamparter

https://github.com/FluentHub/FluentHub/issues/58#issuecomment-1045976174

0x5bfa avatar Jun 04 '22 16:06 0x5bfa

K. I'll take a look later - im deving on the new gu10 branch

Lamparter avatar Jun 04 '22 16:06 Lamparter

Woow, nicee!

0x5bfa avatar Jun 04 '22 16:06 0x5bfa

This app uses GitHub v3 Markdown API. but If we would like to use fluent-svelte style sheets, maybe this will be helpful. https://github.com/pablo-abc/svelte-markdown Do you @DeveloperWOW64 other than?

0x5bfa avatar Jun 07 '22 13:06 0x5bfa

And we need to discuss alternative ways. WebView is very heavy. when use many times, it takes long time to load page. RichTextBlock may be still good way.

0x5bfa avatar Jun 07 '22 13:06 0x5bfa

Do you @DeveloperWOW64 other than?

WDYM?

Lamparter avatar Jun 07 '22 16:06 Lamparter

Do you know other than i told you?

0x5bfa avatar Jun 07 '22 22:06 0x5bfa

Do you know other than i told you?

Other MD css sheets? If so, there's two good ones I found: https://github.com/markdowncss/air https://github.com/jasonm23/markdown-css-themes https://takosthings.github.io/Fluent-Discord/Fluent-Discord.css

It's worth putting some effort in them - maybe we should even create our own

Lamparter avatar Jun 08 '22 06:06 Lamparter

no. I really want to use fluent-svelte's stylesheet. so i thought we need a markdown parser for svelte in order to.

0x5bfa avatar Jun 08 '22 11:06 0x5bfa

alt: maybe we should even create our own

0x5bfa avatar Jun 08 '22 11:06 0x5bfa

but, at the point of view of the app performance, do not like to use WebView, which Heavy and out-dated function.

0x5bfa avatar Jun 08 '22 11:06 0x5bfa

no. I really want to use fluent-svelte's stylesheet. so i thought we need a markdown parser for svelte in order to.

How would we render the svelte? WebView?

Lamparter avatar Jun 08 '22 15:06 Lamparter

yes. and I have 3 ways to display markdown.

Way good bad
WebView -> Svelte -> fluent-svelte very customizable heavy
MarkdownTextBlock -> original resourcec dictionaryb discustomizable light-weight
RichTextBlock -> original user control discostomizable light-weight and can be fluent looks

If we will go with 1, we need a renderer for svelte

For example, https://github.com/pablo-abc/svelte-markdown https://github.com/ssssota/svelte-exmarkdown

0x5bfa avatar Jun 08 '22 15:06 0x5bfa

For example, https://github.com/ssssota/svelte-exmarkdown

The Files website used to use MDSVEX which is svelte-exmarkdown's predecessor

Lamparter avatar Jun 08 '22 15:06 Lamparter

maybe we should even create our own And also, our own css can be good.

0x5bfa avatar Jun 08 '22 15:06 0x5bfa

The Files website used to use MDSVEX which is svelte-exmarkdown's predecessor

We can use that? actually, i dont know about svelte.

0x5bfa avatar Jun 08 '22 15:06 0x5bfa

The Files website used to use MDSVEX which is svelte-exmarkdown's predecessor

We can use that? actually, i dont know about svelte.

Maybe.. 1 is definitely the best option

Lamparter avatar Jun 08 '22 15:06 Lamparter

okay let's go on. other github client app also uses this option, such as JitHub, CodeHub.

0x5bfa avatar Jun 08 '22 15:06 0x5bfa