1444

Results 12 comments of 1444

@superatomic The config file would be required to retain functionality though, as there would no longer be a way to specify custom options. Looking at e.g. zoxide this could also...

Ok, but if we let users alias tere before the init function we pretty much blow up the purpose of the whole init thing. The inlining could be done using...

As this case is relatively simple a ```format!``` might also suffice to insert the arguments instead of using a template engine... A config file would not be required for the...

Yes, backwards compatibility would be given. But both the config file and the inlining of options kind of serve the same purpose: The user would still be able to configure...

Yeah you're right the config file doesnt belong here. What I meant to say is that their purpose overlaps, yet one is not as flexible as the other. So why...

I can see that I should've made my point a little more clear. Yes, `dmps off` turns everything off, but if you then want to turn it back on again...

I've also noticed the implementation to be... odd. Currently whether to enable or disable monitors is calculated only once, instead of per monitor. This works for 'on' and 'off', but...

What should happen if a monitor is specified? `toggleoff` and `toggleon` make little sense in that case. I personally find `toggleon` to be more logical, so maybe just implement that...

To fix this, the `tmpDir` function would need to take an allocator and read the environment variable. (I'd be willing to implement this)

@mattyhall I think this has already been fixed and you forgot to close it? If this is the case, dont forget to remove the mention of it in the README.