Aryan
Aryan
Can I get some context ? What is this commit for ? Why is this commit a problem since false in stdbool is just `#define false 0`
I am not sure if we can push this upstream. But we can definitely make our own addon for this check. Should be easy as all addons work on a...
addon would be pretty small. Probably something like the [findcasts](https://github.com/danmar/cppcheck/blob/main/addons/findcasts.py) addon
An update on `unusedFunction` : ``` Currently unusedFunction needs to see the whole code to avoid false positives making it unfeasible to enable that check on single files only. ```...
> Want to open a PR to run on the whole repo? Any reason not to do this? Running over the whole repo would require a lot of time. Didn't...
hmm.. defining pre-processor symbols like seems to invoke the unusedFunction error. `cppcheck --enable=unusedFunction --quiet -DSTM32F4 -DUID_BASE -DPANDA -DSTM32H7 $PANDA_DIR/board/` Any particular reason you undefined it @adeebshihadeh ? Log: ``` /home/aryan/Desktop/open-source/panda/board/jungle/main.c:169:3:...
`cppcheck --enable=unusedFunction --quiet -DUID_BASE -DPANDA -DSTM32F4 $PANDA_DIR/board/main.c` generates ``` /home/aryan/Desktop/open-source/panda/board/jungle/main.c:169:3: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_INTERRUPT is a macro then please configure it....
Thanks for the efforts @yashchauhan4579 ! Let me know if you run across any issues. I would be happy to guide you.