CelesteNet icon indicating copy to clipboard operation
CelesteNet copied to clipboard

Add Ghost's Dashes value

Open AAA1459 opened this issue 1 year ago • 2 comments

Add Ghost's Dashes value for other mod or colorgrade skin

such as: use player's crolorgrade skin cover to all Ghost, get Ghost's Dashes to match them's colorgrade

AAA1459 avatar Jun 10 '23 09:06 AAA1459

So this is purely for other mods to make use of? I suppose it could be useful once we (finally) get started on having some ModInterop functionality in CelesteNet, to avoid other mods randomly hooking things that break on the next change.

Do you have an example of what this will be used for? I thought maybe this would be related to SMH's CelesteNet-compatibility patches, but I'm not sure.

Anyways, it's unclear to me if this is still work-in-progress - I haven't tested it in any way, but just from reading the changes I can see that the Dashes value isn't written to/read from the transport layer at all 🤔

I'm gonna put some notes on the code changes.

RedFlames avatar Jun 16 '23 17:06 RedFlames

So this is purely for other mods to make use of? I suppose it could be useful once we (finally) get started on having some ModInterop functionality in CelesteNet, to avoid other mods randomly hooking things that break on the next change.

Do you have an example of what this will be used for? I thought maybe this would be related to SMH's CelesteNet-compatibility patches, but I'm not sure.

Anyways, it's unclear to me if this is still work-in-progress - I haven't tested it in any way, but just from reading the changes I can see that the Dashes value isn't written to/read from the transport layer at all 🤔

I'm gonna put some notes on the code changes.

hmmm, Sorry I haven't actually tested it, and I can't find anything else related to these values of Ghost. So I'm not really sure if it works

But about what I want to use it for... like here: https://github.com/AAA1459/SkinModHelper/blob/dev/Code/SkinModHelperModule.cs#L625 Here will directly get the root path of PlayerSprite, for get folder of colorgrades.

that will make Ghost get the colorgrades when any-possible case, so I'm thinking, in order to prevent that any or other case, should make Ghost itself have an dashes value

AAA1459 avatar Jun 17 '23 03:06 AAA1459