fix output bug if symbolization failed

[p0w1]

The "line" variable is not the line itself but prints out all following addresses. Therefore, symbolizer takes forever.

Example of an output before: aggregate2.cov:173: Symbolization of 2635667410264 failed ('0x7ff99b1a5180 0xfffff802230d7495 0x7ff986dc2d5f 0xfffff8021f604d47 0xfffff8021f486345 0x7ff99b1a5259 0x7ff986e72132 [...] endless addresses in stdout

[0vercl0k]

Thanks for the PR! Let me check the code, I haven't looked at it in a long time 😅

[0vercl0k]

@p0w1 do you mind giving #15 a shot? It feels like a more correct fix; this is what it should look like:

>symbolizer.exe -c state\mem.dmp --input ntfs-3g.trace --style fullsym --output .
[...]
GetNameByOffset failed with hr=-2147467259
ntfs-3g.trace:8: Symbolization of 0 failed ('swswsws0xfffff80339dca5d4'), skipping
[1 / 1] ntfs-3g.trace done
Completed symbolization of 1.0k addresses (1.0 failed) in 0.0s across 1.0 files.

[p0w1]

Yes, sure! I thought it's not important because you have the line number anyway. But even better.

[0vercl0k]

Heh, I think it is important and it is a bug so it deserves a proper fix :) I'll merge the other PR this week if this sounds good to you and close this one.

Thanks again for taking the time to report the bug!

Cheers

On Sun, Jan 21, 2024 at 3:12 AM p0w1 @.***> wrote:

Yes, sure! I thought it's not important because you have the line number anyway. But even better.

— Reply to this email directly, view it on GitHub https://github.com/0vercl0k/symbolizer/pull/14#issuecomment-1902595753, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALIORI6VLPZDXS5JFHJOFTYPTZZ7AVCNFSM6AAAAABCBUSV3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGU4TKNZVGM . You are receiving this because you commented.Message ID: @.***>