Logistic-Train-Network icon indicating copy to clipboard operation
Logistic-Train-Network copied to clipboard

Enhancement: round fluid values in log messages

Open nicolas-lang opened this issue 2 years ago • 4 comments

image

nicolas-lang avatar Nov 07 '21 11:11 nicolas-lang

Hi, while it is only a minor inconvenience I think it might be a nice improvement to slightly round the fluid values being displayed in the LTN messages.

(not sure why there is the bug label, it was not my intention to raise this as a bug, sorry)

nicolas-lang avatar Nov 07 '21 11:11 nicolas-lang

Would require either:

  1. rounding fluid values internally
  2. printing different messages for fluids and items

Neither option seems worth it to me.

0ptera avatar Nov 14 '21 07:11 0ptera

I understand that you would consider additional logic just to get this done "not worth it" and I agree 100%.

From my perspective I can't think of any situations were it would be an issue to just round all the numbers in the "itemcount itemtype" part. --> rounding fluids values: intended --> rounding item counts: rounding an integer has no effect --> rounding item stack counts: I don't know if LTN even even supports delivering 3.74 stacks, but I don't see any harm rounding the displayed value to 2 decimals.

This would meant that there is no "additional logic" required, just an additional ceil(...) where the info message is generated.

( P.S. this is very low priority for sure. )

nicolas-lang avatar Nov 14 '21 12:11 nicolas-lang

I too found the weird decimal point cluttering to my UI, and actively searched to try and find a setting to round these numbers to no avail.

danbopes avatar Feb 08 '22 19:02 danbopes