pynalyser
pynalyser copied to clipboard
Partially implemented pyproject.toml file
Implemented a pyproject.toml for pyproject.toml
-
fixes #14 partially Checklist:
-
[x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
-
[ ] Add or update relevant docs, in the
docs
folder and in code docstring. -
[ ] Add an entry in
CHANGES.md
summarizing the change and linking to the issue and your username. -
[ ] Add
*Version changed*
or*Version added*
note in any relevant docs and docstring. -
[ ] Run
pytest
andtox
, no tests failed.
It's nice to see the progress with the pr!
I also will try to land starter docs asap
Nice
@9gl do you plan on adding more changes or do you want me to review and merge?
You can review and merge.I will create new follow up prs
Oh, yeah, forgot to add I left minor suggestions for improvement and a question otherwise LGTM.
Hey! How is it? 😉
Good . I am on it.
Oh, I thought github actions will not pick up on those changes, but actually now when actions try to install the package they use the .toml
.. And that's right, that is what we are after ^_^
So we will need to figure out a way to disable prossibility to use tihs config untill it's done I would propose to rename it, but there may be a better way
Alright, let's finally finish with this, it's better to have at least something merged
If you can't work on this right now, then let's do minimal requreded work and I can finish the rest myself Let's rename the file, fix the indentation and remove the url (https://github.com/0dminnimda/pynalyser/pull/15#discussion_r935813514) And then it'll be good to go ^_^
What do you think, @9gl?
Also, I'm planning to move this repo into organisation @enhance-python (everything stays the same, it's just will be easier to manage teamwork) Can you give me some feedback on the name? Would be nice!
Alright, let's finally finish with this, it's better to have at least something merged
If you can't work on this right now, then let's do minimal requreded work and I can finish the rest myself Let's rename the file, fix the indentation and remove the url (https://github.com/0dminnimda/pynalyser/pull/15#discussion_r935813514) And then it'll be good to go ^_^
What do you think, @9gl?
Ok
Thanks @9gl!
Also @all-contributors let's add @9gl for infra