pynalyser icon indicating copy to clipboard operation
pynalyser copied to clipboard

Partially implemented pyproject.toml file

Open glunkad opened this issue 2 years ago • 6 comments

Implemented a pyproject.toml for pyproject.toml

  • fixes #14 partially Checklist:

  • [x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.

  • [ ] Add or update relevant docs, in the docs folder and in code docstring.

  • [ ] Add an entry in CHANGES.md summarizing the change and linking to the issue and your username.

  • [ ] Add *Version changed* or *Version added* note in any relevant docs and docstring.

  • [ ] Run pytest and tox, no tests failed.

glunkad avatar Aug 01 '22 18:08 glunkad

It's nice to see the progress with the pr!

0dminnimda avatar Aug 01 '22 18:08 0dminnimda

I also will try to land starter docs asap

0dminnimda avatar Aug 01 '22 18:08 0dminnimda

Nice

glunkad avatar Aug 01 '22 18:08 glunkad

@9gl do you plan on adding more changes or do you want me to review and merge?

0dminnimda avatar Aug 02 '22 16:08 0dminnimda

You can review and merge.I will create new follow up prs

glunkad avatar Aug 02 '22 16:08 glunkad

Oh, yeah, forgot to add I left minor suggestions for improvement and a question otherwise LGTM.

0dminnimda avatar Aug 02 '22 20:08 0dminnimda

Hey! How is it? 😉

0dminnimda avatar Aug 15 '22 00:08 0dminnimda

Good . I am on it.

glunkad avatar Aug 16 '22 19:08 glunkad

Oh, I thought github actions will not pick up on those changes, but actually now when actions try to install the package they use the .toml .. And that's right, that is what we are after ^_^

So we will need to figure out a way to disable prossibility to use tihs config untill it's done I would propose to rename it, but there may be a better way

0dminnimda avatar Aug 16 '22 19:08 0dminnimda

Alright, let's finally finish with this, it's better to have at least something merged

If you can't work on this right now, then let's do minimal requreded work and I can finish the rest myself Let's rename the file, fix the indentation and remove the url (https://github.com/0dminnimda/pynalyser/pull/15#discussion_r935813514) And then it'll be good to go ^_^

What do you think, @9gl?

0dminnimda avatar Aug 21 '22 18:08 0dminnimda

Also, I'm planning to move this repo into organisation @enhance-python (everything stays the same, it's just will be easier to manage teamwork) Can you give me some feedback on the name? Would be nice!

0dminnimda avatar Aug 21 '22 18:08 0dminnimda

Alright, let's finally finish with this, it's better to have at least something merged

If you can't work on this right now, then let's do minimal requreded work and I can finish the rest myself Let's rename the file, fix the indentation and remove the url (https://github.com/0dminnimda/pynalyser/pull/15#discussion_r935813514) And then it'll be good to go ^_^

What do you think, @9gl?

Ok

glunkad avatar Aug 21 '22 19:08 glunkad

Thanks @9gl!

0dminnimda avatar Aug 22 '22 08:08 0dminnimda

Also @all-contributors let's add @9gl for infra

0dminnimda avatar Aug 22 '22 08:08 0dminnimda

@0dminnimda

I've put up a pull request to add @9gl! :tada:

allcontributors[bot] avatar Aug 22 '22 08:08 allcontributors[bot]