zboxcli
zboxcli copied to clipboard
throw non zero exit status on failure of copy and move command
A brief description of the changes in this PR:
fixes https://github.com/0chain/zboxcli/issues/251
Tasks to complete before merging PR:
- [ ] Ensure system tests are passing. If not Run them manually to check for any regressions :clipboard:
- [ ] Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
- [ ] Merge your system tests PR to master AFTER merging this PR
Associated PRs (Link as appropriate):
- 0chain:
- blobber:
- gosdk:
- system_test:
- zwalletcli:
- Other: ...
@cnlangzi updated the PR as per comments. PTAL
@cnlangzi updated the PR as per comments. PTAL
os.Exit(1)
can be removed , because panic will throw 1 now
@boddumanohar please also fix related system_tests, thanks.
Manual system tests [failure] with the following config
config | value |
---|---|
tests skipped | FALSE |
system-tests | file-copy |
gosdk | staging |
zboxcli | 251 |
zwalletcli | staging |
0chain | staging |
blobber | staging |
authorizer | staging |
0box | staging |
0block | staging |
0dns | staging |
explorer | staging |
0proxy | staging |
0search | staging |
Manual system tests [cancelled] with the following config
config | value |
---|---|
tests skipped | FALSE |
system-tests | file-copy |
gosdk | staging |
zboxcli | 251 |
zwalletcli | staging |
0chain | staging |
blobber | staging |
authorizer | staging |
0box | staging |
0block | staging |
0dns | staging |
explorer | staging |
0proxy | staging |
0search | staging |
Manual system tests [failure] with the following config
config | value |
---|---|
tests skipped | FALSE |
system-tests | master |
gosdk | staging |
zboxcli | 251 |
zwalletcli | staging |
0chain | staging |
blobber | staging |
authorizer | staging |
0box | staging |
0block | staging |
0dns | staging |
explorer | staging |
0proxy | staging |
0search | staging |
@boddumanohar please fix the system tests https://github.com/0chain/system_test/tree/file-copy.
Manual system tests [failure] with the following config
config | value |
---|---|
tests skipped | FALSE |
system-tests | file-copy |
gosdk | staging |
zboxcli | 251 |
zwalletcli | staging |
0chain | staging |
blobber | staging |
authorizer | staging |
0box | staging |
0dns | staging |
Manual system tests [success] with the following config
config | value |
---|---|
tests skipped | TRUE |
system-tests | file-copy |
gosdk | staging |
zboxcli | 251 |
zwalletcli | staging |
0chain | staging |
blobber | staging |
authorizer | staging |
0box | staging |
0dns | staging |
Manual system tests [success] with the following config
config | value |
---|---|
tests skipped | TRUE |
system-tests | file-copy |
gosdk | staging |
zboxcli | staging |
zwalletcli | staging |
0chain | staging |
blobber | staging |
authorizer | staging |
0box | staging |
0dns | staging |