zboxcli icon indicating copy to clipboard operation
zboxcli copied to clipboard

throw non zero exit status on failure of copy and move command

Open boddumanohar opened this issue 2 years ago • 6 comments

A brief description of the changes in this PR:

fixes https://github.com/0chain/zboxcli/issues/251

Tasks to complete before merging PR:

  • [ ] Ensure system tests are passing. If not Run them manually to check for any regressions :clipboard:
  • [ ] Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • [ ] Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

boddumanohar avatar Sep 30 '22 15:09 boddumanohar

@cnlangzi updated the PR as per comments. PTAL

boddumanohar avatar Oct 12 '22 13:10 boddumanohar

@cnlangzi updated the PR as per comments. PTAL

os.Exit(1) can be removed , because panic will throw 1 now

cnlangzi avatar Oct 12 '22 23:10 cnlangzi

@boddumanohar please also fix related system_tests, thanks.

cnlangzi avatar Oct 17 '22 22:10 cnlangzi

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests file-copy
gosdk staging
zboxcli 251
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Oct 27 '22 23:10 service-0chain

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests file-copy
gosdk staging
zboxcli 251
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Nov 01 '22 11:11 service-0chain

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk staging
zboxcli 251
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Nov 01 '22 12:11 service-0chain

@boddumanohar please fix the system tests https://github.com/0chain/system_test/tree/file-copy.

peterlimg avatar Feb 25 '23 23:02 peterlimg

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests file-copy
gosdk staging
zboxcli 251
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0dns staging

service-0chain avatar Apr 13 '23 15:04 service-0chain

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests file-copy
gosdk staging
zboxcli 251
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0dns staging

service-0chain avatar Apr 16 '23 19:04 service-0chain

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests file-copy
gosdk staging
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0dns staging

service-0chain avatar Apr 16 '23 20:04 service-0chain