gosdk icon indicating copy to clipboard operation
gosdk copied to clipboard

Published 20 hours ago • verified publisher icon 0chain

chain fee sdk

Open bisakhmondal opened this issue 1 year ago • 6 comments

Changes

  • zcncore SDK method to calculate the suggested chain fee.

Fixes

Tests

Tasks to complete before merging PR:

  • [ ] Ensure system tests are passing. If not Run them manually to check for any regressions :clipboard:
  • [ ] Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • [ ] Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain: https://github.com/0chain/0chain/pull/1753
  • system_test: https://github.com/0chain/system_test/pull/464
  • zboxcli: https://github.com/0chain/zboxcli/pull/316
  • zwalletcli: https://github.com/0chain/zwalletcli/pull/184
  • Other: ...

bisakhmondal avatar Oct 26 '22 22:10 bisakhmondal

Hey, thanks @stewartie4.

utils.go:74: 0box-sdk        [DEBUG]  2022/10/28 00:18:21.153386 networkworker.go:105: Get network result:{"miners":["https://dev-2.devnet-0chain.net/miner02","https://dev-2.devnet-0chain.net/miner01","https://dev-2.devnet-0chain.net/miner03"],"sharders":["https://dev-2.devnet-0chain.net/sharder02","https://dev-2.devnet-0chain.net/sharder01"]}
    utils.go:74: Error creating allocation: failed to calculate suggested fee, failed to fetch data from miners

I think it's RE pr #https://github.com/0chain/0chain/pull/1753 We have to redeploy devnet as it's add a new API and the current feature depends on that.

Seen same error in https://github.com/0chain/zwalletcli/pull/184#issuecomment-1294026271

RE systems tests, I think we can add some (mock tests probably) for the 0chain PR1753. Could you please guide me? Thanks.

bisakhmondal avatar Oct 31 '22 08:10 bisakhmondal

Hey guys, I think merging the following PRs (in the order) will solve the system tests ci

  • https://github.com/0chain/system_test/pull/464
  • https://github.com/0chain/zboxcli/pull/316

bisakhmondal avatar Nov 02 '22 09:11 bisakhmondal

Hey guys, I think merging the following PRs (in the order) will solve the system tests ci

Ping. Guys, let me know if you are okay with the PR. IIUC, for the systems tests, we need the aforesaid PRs to be merged. cc @dabasov @peterlimg Thanks

bisakhmondal avatar Nov 06 '22 10:11 bisakhmondal

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests chain-fee-integration
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Nov 09 '22 05:11 service-0chain

@bisakhmondal please run system tests manually with related branches of gosdk, zboxcli, zwalletcli and system tests, we will need to see the system tests pass before merging them.

peterlimg avatar Nov 09 '22 05:11 peterlimg

The system tests are failing on staking blobbers because the changes use the estimated txn cost *1e10 as transaction fee, which is totally wrong and the txn will be rejected due to the large fee setting. We will need to figure out the coefficient for converting the cost to fee.

peterlimg avatar Nov 15 '22 04:11 peterlimg

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee
blobber chain-fee
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Feb 27 '23 19:02 service-0chain

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee
blobber chain-fee
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Feb 27 '23 19:02 service-0chain

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli chain-fee
0chain chain-fee
blobber chain-fee
authorizer chain-fee
0box chain-fee
0block staging
0dns staging
explorer master
0proxy staging
0search staging

service-0chain avatar Mar 18 '23 01:03 service-0chain

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee
blobber chain-fee
authorizer chain-fee
0box chain-fee
0block staging
0dns staging
explorer master
0proxy staging
0search staging

service-0chain avatar Mar 18 '23 03:03 service-0chain

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee
blobber chain-fee
authorizer chain-fee
0box chain-fee
0block staging
0dns staging
explorer master
0proxy staging
0search staging

service-0chain avatar Mar 18 '23 04:03 service-0chain

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee
blobber chain-fee
authorizer chain-fee
0box chain-fee
0block staging
0dns staging
explorer master
0proxy staging
0search staging

service-0chain avatar Mar 31 '23 06:03 service-0chain

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee
blobber chain-fee
authorizer chain-fee
0box chain-fee
0block staging
0dns staging
explorer master
0proxy staging
0search staging

service-0chain avatar Mar 31 '23 12:03 service-0chain

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee
blobber chain-fee
authorizer chain-fee
0box chain-fee
0block staging
0dns staging
explorer master
0proxy staging
0search staging

service-0chain avatar Apr 01 '23 01:04 service-0chain

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee
blobber chain-fee
authorizer chain-fee
0box chain-fee
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Apr 12 '23 23:04 service-0chain

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee
blobber chain-fee
authorizer chain-fee
0box chain-fee
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Apr 13 '23 14:04 service-0chain

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee
blobber chain-fee
authorizer chain-fee
0box chain-fee
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Apr 17 '23 00:04 service-0chain

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee-v2
blobber chain-fee
authorizer chain-fee
0box chain-fee
0dns staging

service-0chain avatar Apr 17 '23 04:04 service-0chain

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests chain-fee
gosdk chain-fee
zboxcli chain-fee
zwalletcli feat/chain-fee
0chain chain-fee-v2
blobber chain-fee
authorizer chain-fee
0box chain-fee
0dns staging

service-0chain avatar Apr 17 '23 05:04 service-0chain