blobber icon indicating copy to clipboard operation
blobber copied to clipboard

Modify wm for gdpr

Open lpoli opened this issue 2 years ago • 5 comments

Changes

This PR is implementation of https://github.com/0chain/gosdk/issues/570. It has added few fields in writemarker and also uses fileMetaRoot to determine if all the blobbers are in sync with each other or not. fileMetaRoot can be used to repair files in an allocation.

Fixes

Tests

Tasks to complete before merging PR:

  • [ ] Ensure system tests are passing. If not Run them manually to check for any regressions :clipboard:
  • [ ] Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • [ ] Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain: https://github.com/0chain/0chain/pull/1791
  • gosdk: https://github.com/0chain/gosdk/pull/637
  • system_test: https://github.com/0chain/system_test/pull/474
  • zboxcli: https://github.com/0chain/zboxcli/pull/324
  • zwalletcli:
  • Other: ...

lpoli avatar Nov 07 '22 06:11 lpoli

Codecov Report

Merging #870 (c35f006) into staging (66dd5eb) will decrease coverage by 0.40%. The diff coverage is 25.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging     #870      +/-   ##
===========================================
- Coverage    26.58%   26.18%   -0.40%     
===========================================
  Files           76       76              
  Lines         7707     7744      +37     
===========================================
- Hits          2049     2028      -21     
- Misses        5390     5444      +54     
- Partials       268      272       +4     
Flag Coverage Δ
Unit-Tests 26.18% <25.00%> (-0.40%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain.net/blobbercore/allocation/allocationchange.go 0.00% <0.00%> (ø)
...ain.net/blobbercore/allocation/deletefilechange.go 0.00% <0.00%> (ø)
...ode/go/0chain.net/blobbercore/allocation/entity.go 0.00% <ø> (ø)
.../0chain.net/blobbercore/allocation/newdirchange.go 0.00% <0.00%> (ø)
...e/go/0chain.net/blobbercore/allocation/protocol.go 0.00% <0.00%> (ø)
...de/go/0chain.net/blobbercore/allocation/workers.go 0.00% <0.00%> (ø)
...et/blobbercore/handler/object_operation_handler.go 30.82% <0.00%> (-0.71%) :arrow_down:
.../0chain.net/blobbercore/handler/storage_handler.go 23.28% <ø> (ø)
code/go/0chain.net/blobbercore/reference/ref.go 0.00% <0.00%> (ø)
.../0chain.net/blobbercore/reference/referencepath.go 0.00% <0.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Nov 09 '22 09:11 codecov-commenter

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk enhancement/modify-wm-for-gdpr
zboxcli staging
zwalletcli staging
0chain enhancement/modify-wm-for-gdpr
blobber modify-wm-for-gdpr
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Nov 10 '22 01:11 service-0chain

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli enhancement/modify-wm-for-gdpr
zwalletcli staging
0chain enhancement/modify-wm-for-gdpr
blobber modify-wm-for-gdpr
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

service-0chain avatar Nov 16 '22 04:11 service-0chain

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli enhancement/modify-wm-for-gdpr
zwalletcli staging
0chain enhancement/modify-wm-for-gdpr
blobber modify-wm-for-gdpr
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

service-0chain avatar Nov 16 '22 05:11 service-0chain

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests enhancement/modify-wm-for-gdpr
gosdk NOT OVERRIDDEN
zboxcli enhancement/modify-wm-for-gdpr
zwalletcli staging
0chain enhancement/modify-wm-for-gdpr
blobber modify-wm-for-gdpr
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

service-0chain avatar Nov 17 '22 02:11 service-0chain

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests enhancement/modify-wm-for-gdpr
gosdk NOT OVERRIDDEN
zboxcli enhancement/modify-wm-for-gdpr
zwalletcli staging
0chain enhancement/modify-wm-for-gdpr
blobber modify-wm-for-gdpr
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

service-0chain avatar Dec 27 '22 13:12 service-0chain

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests enhancement/modify-wm-for-gdpr
gosdk enhancement/modify-wm-for-gdpr
zboxcli enhancement/modify-wm-for-gdpr
zwalletcli staging
0chain enhancement/modify-wm-for-gdpr
blobber modify-wm-for-gdpr
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Feb 26 '23 11:02 service-0chain

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests enhancement/modify-wm-for-gdpr
gosdk enhancement/modify-wm-for-gdpr
zboxcli enhancement/modify-wm-for-gdpr
zwalletcli staging
0chain enhancement/modify-wm-for-gdpr
blobber modify-wm-for-gdpr
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Feb 28 '23 04:02 service-0chain

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests enhancement/modify-wm-for-gdpr
gosdk enhancement/modify-wm-for-gdpr
zboxcli enhancement/modify-wm-for-gdpr
zwalletcli fix-rounding-off-for-balance
0chain enhancement/modify-wm-for-gdpr
blobber modify-wm-for-gdpr
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Mar 01 '23 09:03 service-0chain

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests enhancement/modify-wm-for-gdpr
gosdk enhancement/modify-wm-for-gdpr
zboxcli enhancement/modify-wm-for-gdpr
zwalletcli staging
0chain enhancement/modify-wm-for-gdpr
blobber modify-wm-for-gdpr
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Mar 02 '23 03:03 service-0chain

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests enhancement/modify-wm-for-gdpr
gosdk enhancement/modify-wm-for-gdpr
zboxcli enhancement/modify-wm-for-gdpr
zwalletcli staging
0chain enhancement/modify-wm-for-gdpr
blobber modify-wm-for-gdpr
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

service-0chain avatar Mar 02 '23 04:03 service-0chain