blobber icon indicating copy to clipboard operation
blobber copied to clipboard

Allocation ownership transfer is not synced from 0chain

Open peterlimg opened this issue 2 years ago • 8 comments

Related issue https://github.com/0chain/gosdk/issues/765

peterlimg avatar Jun 15 '22 01:06 peterlimg

@peterlimg all allocation changes should be synced from blockchain. eg size, write_price, read_price...etc

cnlangzi avatar Jun 17 '22 00:06 cnlangzi

@peterlimg @cnlangzi What should be done to this issue?

lpoli avatar Jun 24 '22 11:06 lpoli

@peterlimg @cnlangzi can you please give a brief overview on what should done as a part of this ticket?

boddumanohar avatar Nov 13 '22 23:11 boddumanohar

@boddumanohar first, we need to confirm if this bug still exist. So after transferring an allocation's ownership, check if the new owner has the CURD rights? and if how about the old owner.

Second, if the bug still exists, then we will need to check what we can do to fix the issue, most likely as @cnlangzi said above, it is because the ownership data hasn't been sync from 0chain, so perhaps, what we can do are:

  • Update the zboxcli to send message to blobbers to trigger allocation info synching after the ownership transfer txn is confirmed.
  • Implement the sync processor on blobbers.

Another way is to do whole allocations synching periodically, but that may use a lot of resources and cause performance issue as each blobber could have a lot of allocations need to update.

peterlimg avatar Nov 14 '22 05:11 peterlimg

@peterlimg just checking if this is still a valid issue, we still see flaky behaviour/periodic test failures

stewartie4 avatar Dec 17 '22 13:12 stewartie4

@stewartie4 yes, I've validated and the issue still exists. At the moment, @lpoli is working on it. As is somewhat related to his Writemarker modification PR.

The problem is with respect to write maker signature verification. And the associated discussion can be followed here: https://0chain.slack.com/archives/C01U94VF56Y/p1668931208557289

boddumanohar avatar Dec 17 '22 14:12 boddumanohar

@peterlimg this function https://github.com/0chain/blobber/blob/staging/code/go/0chain.net/blobbercore/handler/storage_handler.go#L41 , updates the allocation right , if yes can we just call this function when zbox cli send the update request with txnhash of update owner transaction .

Hitenjain14 avatar Mar 11 '23 21:03 Hitenjain14

postponed

dabasov avatar Mar 18 '23 19:03 dabasov