blobber icon indicating copy to clipboard operation
blobber copied to clipboard

Aggregate sig

Open Hitenjain14 opened this issue 1 year ago • 2 comments

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • [ ] Ensure system tests are passing. If not Run them manually to check for any regressions :clipboard:
  • [ ] Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • [ ] Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain: https://github.com/0chain/0chain/pull/3078
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

Hitenjain14 avatar Jan 03 '24 14:01 Hitenjain14

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain
blobber feat/aggregate-sig
authorizer
0box
0dns

service-0chain avatar Jan 03 '24 15:01 service-0chain

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (3402040) 23.50% compared to head (5ac7041) 14.38%.

Files Patch % Lines
...e/go/0chain.net/blobbercore/challenge/challenge.go 0.00% 18 Missing :warning:
code/go/0chain.net/core/common/handler/worker.go 0.00% 16 Missing :warning:
code/go/0chain.net/blobbercore/challenge/worker.go 0.00% 13 Missing :warning:
code/go/0chain.net/core/encryption/keys.go 13.33% 12 Missing and 1 partial :warning:
code/go/0chain.net/blobbercore/challenge/entity.go 0.00% 7 Missing :warning:
...de/go/0chain.net/blobbercore/challenge/protocol.go 0.00% 5 Missing :warning:
...ain.net/validatorcore/storage/challenge_handler.go 0.00% 3 Missing :warning:
code/go/0chain.net/validatorcore/storage/models.go 62.50% 1 Missing and 2 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           sprint-1.12    #1362      +/-   ##
===============================================
- Coverage        23.50%   14.38%   -9.13%     
===============================================
  Files               87      177      +90     
  Lines            10196    19912    +9716     
===============================================
+ Hits              2397     2865     +468     
- Misses            7502    16689    +9187     
- Partials           297      358      +61     
Flag Coverage Δ
Unit-Tests 14.38% <8.23%> (-9.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 03 '24 15:01 codecov-commenter