blobber
blobber copied to clipboard
Aggregate sig
Changes
Fixes
Tests
Tasks to complete before merging PR:
- [ ] Ensure system tests are passing. If not Run them manually to check for any regressions :clipboard:
- [ ] Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
- [ ] Merge your system tests PR to master AFTER merging this PR
Associated PRs (Link as appropriate):
- 0chain: https://github.com/0chain/0chain/pull/3078
- gosdk:
- system_test:
- zboxcli:
- zwalletcli:
- Other: ...
Manual system tests [failure] with the following config
config | value |
---|---|
tests skipped | false |
system-tests | |
gosdk | NOT OVERRIDDEN |
zboxcli | |
zwalletcli | |
0chain | |
blobber | feat/aggregate-sig |
authorizer | |
0box | |
0dns |
Codecov Report
Attention: 78 lines
in your changes are missing coverage. Please review.
Comparison is base (
3402040
) 23.50% compared to head (5ac7041
) 14.38%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## sprint-1.12 #1362 +/- ##
===============================================
- Coverage 23.50% 14.38% -9.13%
===============================================
Files 87 177 +90
Lines 10196 19912 +9716
===============================================
+ Hits 2397 2865 +468
- Misses 7502 16689 +9187
- Partials 297 358 +61
Flag | Coverage Δ | |
---|---|---|
Unit-Tests | 14.38% <8.23%> (-9.13%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.