0chain
0chain copied to clipboard
PutTransaction fixes
Fixes
Close #1387
Changes
Need to be mentioned in CHANGELOG.md?
Tests
Tasks to complete before merging PR:
- [ ] Ensure system tests are passing. If not Run them manually to check for any regressions :clipboard:
- [ ] Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
- [ ] Merge your system tests PR to master AFTER merging this PR
Associated PRs (Link as appropriate):
- blobber:
- gosdk:
- system_test:
- zboxcli:
- zwalletcli:
- Other: ...
Codecov Report
Merging #1531 (c0ba3da) into staging (c8746a3) will increase coverage by
0.00%. The diff coverage is0.00%.
@@ Coverage Diff @@
## staging #1531 +/- ##
========================================
Coverage 28.80% 28.80%
========================================
Files 359 359
Lines 58606 58619 +13
========================================
+ Hits 16883 16887 +4
- Misses 39822 39829 +7
- Partials 1901 1903 +2
| Flag | Coverage Δ | |
|---|---|---|
| Unit-Tests | 28.80% <0.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ode/go/0chain.net/chaincore/chain/block_fetcher.go | 2.41% <ø> (ø) |
|
| code/go/0chain.net/chaincore/chain/entity.go | 10.44% <0.00%> (-0.02%) |
:arrow_down: |
| code/go/0chain.net/chaincore/chain/handler.go | 8.09% <0.00%> (-0.06%) |
:arrow_down: |
| code/go/0chain.net/core/datastore/worker.go | 97.26% <0.00%> (-2.74%) |
:arrow_down: |
| ...ain.net/smartcontract/storagesc/config_settigns.go | 32.36% <0.00%> (ø) |
|
| ...de/go/0chain.net/smartcontract/vestingsc/config.go | 53.88% <0.00%> (+3.10%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Manual system tests [success] with the following config
| config | value |
|---|---|
| tests skipped | FALSE |
| system-tests | master |
| gosdk | NOT OVERRIDDEN |
| zboxcli | staging |
| zwalletcli | staging |
| 0chain | rrrooommmaaa/issue-1387 |
| blobber | staging |
| authorizer | staging |
| 0box | staging |
| 0block | staging |
| 0dns | staging |
| explorer | master |
| 0proxy | staging |
| 0search | staging |
Manual system tests [failure] with the following config
| config | value |
|---|---|
| tests skipped | FALSE |
| system-tests | master |
| gosdk | NOT OVERRIDDEN |
| zboxcli | staging |
| zwalletcli | staging |
| 0chain | rrrooommmaaa/issue-1387 |
| blobber | staging |
| authorizer | staging |
| 0box | staging |
| 0block | staging |
| 0dns | staging |
| explorer | master |
| 0proxy | staging |
| 0search | staging |