Dalamud-VFXEditor icon indicating copy to clipboard operation
Dalamud-VFXEditor copied to clipboard

new update window reversed

Open XCZA opened this issue 2 years ago • 2 comments

Awesome first of all! I see you implemented the Original and Custom, but they are currently reversed: Here you can see this is what I see after i click the magnifying glass for loaded VFx (which would be the modified file)

image

XCZA avatar Dec 10 '22 07:12 XCZA

After using the new names a bit, I'm probably gonna change them to something like [SOURCE] and [TO REPLACE], since Original/Modified seems a bit ambiguous sometimes.

For example, does "Original" mean the original data (that you load), or the original path (that's being replaced).

0ceal0t avatar Dec 15 '22 22:12 0ceal0t

yeah i hear, what about [CLIENT FILE] and [REPLACEMENT FILE] If you just did replacement, it could be the same issue as source, ie, is the replacement the thing being replaced or the replacee. really most pairs of adjectives or descriptive nouns will run into that conundrum, but i think just adding the word file in there removes the ambiguity. It's hard to confuse the Replacement File with the game's (original/native/client) file. likewise, a client file can only be read two ways, and in most cases people are gonna understand client as in 'game client' and not a partner 'client'.

other possibilities in the same vein would be: [GAME CLIENT FILE] and [YOUR REPLACEMENT FILE]
[UNMODIFIED FILE] and [YOUR CUSTOM FILE] [ORIGINAL CLIENT FILE] and [YOUR NEW FILE] etc...

XCZA avatar Dec 22 '22 11:12 XCZA