jaq-json: implement `serde::Deserialize` for `jaq_json::Value`
I'm building a tool that lets you search through unity game objects using jq at https://github.com/jakobhellermann/uniscan/
With this change, I can directly deserialize the internal game files directly into jaq_json::Value and query them, without going through an intermediate format.
I gated this behind a feature, but looking at it now I'm not sure that it is necessary. It doesn't introduce any new dependencies and I can't imagine the code adds that much to compile times.
Hi @jakobhellermann, that looks already quite good!
It's a very good thing that you gated this behind a feature, because as far as I can see, it does add a dependency on serde, which one should be able to disable.
Could you add some tests to jaq-json for this new functionality?
Cool tool, by the way (uniscan). :)
Thanks :)
I've addressed the comments (in the other PR as well).
Hi @jakobhellermann, thanks for your improvements.
Still, I do not see any tests for your code yet. Tests are important to me, otherwise I cannot refactor fearlessly. One function or so in your serde.rs with #[test] where you run through all your code paths would suffice.