private-gpt icon indicating copy to clipboard operation
private-gpt copied to clipboard

add Dockerfile

Open mpadge opened this issue 2 years ago • 8 comments
trafficstars

Thanks for the invitation @imartinez . This is only a draft for now, because we need to decide whether it should have endpoints exposed.

mpadge avatar May 12 '23 10:05 mpadge

I would suggest to use an alpine image instead of ubuntu. Alpine is lightweight, no bloatware and a lot faster than ubuntu

thebigbone avatar May 12 '23 11:05 thebigbone

I'd also suggest to use the COPY directive instead of cloning with git this repository. It makes the build faster and doesn't need to connect to Github servers but instead it allows to source directly from the local copy.

Polpetta avatar May 12 '23 12:05 Polpetta

@imartinez Current form works, as provides at least a simple start. Would you like me to update docs as well before merging, or after?

@Polpetta Great idea, feel free to add to PR

@thebigbone ubuntu is a safe fallback because it's an image that people are way more likely to already have than any others. Size is not an issue because the image ends up > 15GB anyway, so starting sizes are completely irrelevant. But it's @imartinez's repo anyway, who ultimately gets to decide what base image to use.

mpadge avatar May 12 '23 12:05 mpadge

The problem with using ubuntu images is that by being bigger they also introduce more possible vulns.

vilaca avatar May 12 '23 12:05 vilaca

Doing the lords work here @mpadge

tgh19 avatar May 13 '23 20:05 tgh19

@mpadge thanks for the work! Please update the readme presenting this as an alternative way of getting the project running. Try to make it super clear, taking into account there is a lot of people checking out this repo, and not everyone is an experienced SW dev. We can merge it once you got it. Thanks!!

imartinez avatar May 14 '23 07:05 imartinez

https://github.com/imartinez/privateGPT/issues/90#issuecomment-1546902884 ubuntu:latest doesn't work, tested.

hanwsf avatar May 14 '23 13:05 hanwsf

Hello i made another that using dockerfile and compose #120

JulienA avatar May 14 '23 13:05 JulienA

@imartinez I'm going to close this in favour of #120 from @JulienA. docker-compose is definitely the way to go, to separate the install and ingest steps.

mpadge avatar May 15 '23 07:05 mpadge