clang-format.style is shown as unknown configuration setting

[smnbbrv]

trafficstars

Hi, thanks for your plugin! I use it every day.

There is a small issue with settings: clang-format.style is not recognized by the vscode.

I assume some registration of plugin configuration is required...

[zxh0]

I can not reproduce this on my macBook :(

[hamidzr]

should you be passing in valid json instead of a string? eg remove the quotes around {} ?

[smnbbrv]

That's the only way I made it work at the moment I was trying... just did not work as object

[smnbbrv]

@zxh0 looks like I found the reason.

Today with new vscode formatting got completely broken and I searched for what's missing and found out that Clang-Format plugin was not installed in my VSCode.

After installation, this issue gets resolved. However, this is weird because now I need to enable the formatter from Clang-Format with the following:

  "[proto3]": {
        "editor.defaultFormatter": "xaver.clang-format"
    },

which actually gives another warning

Value is not accepted. Valid values: null, "vscode.configuration-editing", ..., "zxh404.vscode-proto3".

but properly formats the files.

After VSCode restart the warning is gone. So, all fine

What is unclear to me is:

• if this plugin depends on the Clang-Format, why isn't it automatically installed
• if this plugin depends on the Clang-Format, why it also offers the second formatter
• if it does not depend on Clang-Format plugin, well, then it's unclear why it is referred in the docs as a solution :)

With the latter I mean this

[xh3b4sd]

Just posted a comment in https://github.com/zxh0/vscode-proto3/pull/39#issuecomment-729070753. I cannot make the formatting work either and I am not sure what I am missing.