elm-coverage icon indicating copy to clipboard operation
elm-coverage copied to clipboard

Better support for locally installed tools

Open robyoder opened this issue 3 years ago • 2 comments

The --elm-test arg was only working with absolute paths, and a locally installed copy of elm wouldn't work at all.

Using path.resolve seemed like a pretty straightforward fix for elm-test, but then I realized the default value for the arg was "elm-test", which is definitely not meant to be resolved as a relative path. I'm not sure what the cleanest way to approach this would be, but I took the perspective that anyone setting it to something other than the default is most likely to be using a path, not another name meant to be resolved by Node, so we can just resolve the value as a relative path if it's not the default value.

For elm, I noticed in #20 that @zwilias had recommended using npm-which, and that did the trick nicely.

I've not added tests because it's getting late and I'm just trying to get this working for my project and I wasn't actually totally sure how to test the elm one anyway. I'd love any guidance on this.

Resolves #45

robyoder avatar Jan 27 '22 06:01 robyoder

Hello. Did you first install the package, with python install setup.py ? When do you receive the error? When running the small test program (rpi-TM1638/test/test_TM.py) ?

Thibault

thilaire avatar Mar 07 '19 15:03 thilaire

Hi, I encountered the same issue when running both test.

Installation

git clone https://github.com/thilaire/rpi-TM1638.git
cd rpi-TM1638/
sudo python setup.py install

Error

from rpi_TM1638 import TMBoards
ModuleNotFoundError: No module named 'rpi_TM1638'

ricsci avatar Feb 27 '21 22:02 ricsci