node-zwave-js icon indicating copy to clipboard operation
node-zwave-js copied to clipboard

Published 20 hours ago • verified publisher icon zwave-js

feat: make ZWaveNode class also emit it's events via this.driver.emit

Open sdrsdr opened this issue 3 years ago • 2 comments

As described in #4914 it will be very hand to be able to subscribe for all network events via the driver event emitter, and this PR enables this. It's just a suggestion, I don't fully understand the typing of the event emitters but my typescript is happy with what I've done. Any suggestions are highly welcomed :)

sdrsdr avatar Aug 15 '22 18:08 sdrsdr

Hey, just wanted to let you know - I haven't forgotten this, but I need to get a couple of things stabilized before QoL things like this can land.

AlCalzone avatar Sep 13 '22 13:09 AlCalzone

No rush 😃 I'm using the package from my repo thanks to yarn. I'm glad that you even consider this feature

sdrsdr avatar Sep 13 '22 19:09 sdrsdr

Sorry, totally lost track of this while focusing on getting the driver ready for certification. Will take a look on monday.

AlCalzone avatar Jul 02 '23 12:07 AlCalzone

Ah don't worry, I might endup maintaining a fork for our own needs so you can totally drop ths if you don't like it

sdrsdr avatar Jul 02 '23 13:07 sdrsdr