excelize
excelize copied to clipboard
zurmokeeper
[Q] Existing Header Image is not supported
💬 Existing Header image is not supported
Header images are currently being removed in Microsoft Excel when using ExcelJS.
The feature to handle this issue is addressed in https://github.com/exceljs/exceljs/pull/2563; however, shapes and comments are also being removed despite being supported in the latest ExcelJS version (4.4.0).
According to https://github.com/exceljs/exceljs/discussions/2574, version 4.5.0 is expected to fully support this functionality. However, I would like to utilize this feature now.
@zurmokeeper, could you merge this into your branch, or provide guidance on how to proceed? Your assistance would be greatly appreciated.
@Sarsewar
From the comments under PR https://github.com/exceljs/exceljs/pull/2563 , does it mean that just merging PR 2563 meets your functional requirements? Or does it still need the content of PR 2077 to make your requirement work?
@zurmokeeper 2563 meets functional requirements of header image support but I guess it has bugs . The existing comments and drawing shapes were being removed. But Exceljs latest version 4.4.0 supports comments and drawing shapes. I want all three(header image,comments & Drawing shapes) to work in a single version.
@Sarsewar I'll take a look with this branch of the code, if it's the same as stated here, then there should be a compatibility issue with MS Office, right?
https://github.com/exceljs/exceljs/pull/2077
https://github.com/exceljs/exceljs/pull/2601