zulip
zulip copied to clipboard
zulip
"Display left side userlist in narrows" doesn't work with pinned streams
If you use the "Display settings" setting, "Display left side userlist in narrows", and pin some streams, the left sidebar will look like this:
(The bug is that the normal streams are in a scrollable area on top of the USERS area)
Hello @zulip/server-sidebars members, this issue was labeled with the area: left-sidebar label, so you may want to check it out!
@timabbott I can't find the "Display left side userlist in narrows" in the "Zulip Labs" setting. Has it been removed as of now?
@timabbott I don't see the bug here. In your image the streams are above the users.
I guess I should have posted a taller screenshot, but basically it shows literally only those 4 streams in a tiny scrollable area, and then spends a lot of space on the users part of the sidebar. What I was suggesting is that perhaps we should make the whole section with both streams and users a scrollable area.
this issue is irrelevant now because the users section is moved to right side now
@Redarcher9 It's always been the case that most users have the buddy list in the right sidebar, but we still have a setting where you can display the user list in the left sidebar. So I think this issue is still relevant to some folks.
@timabbott @showell Is this issue still relevant? Can't seem to reproduce on master (#all is an unpinned stream)
@synicalsyntax quite possibly not; try with a window of that window but 50% taller?
Yes, this issue is still valid. I reproduced this today:
The actual issue here is I think that the architecture of the scrollable regions is wrong; the USERS block should be below all streams, rather than having a scrollable region containing (pinned streams, then streams) with not much height followed by a similar one for USERS, each with a fixed height.
I think what we want, at least in this range of windows heights, is to have a top-level scrollable region like this:
STREAMS
So that we don't have widgets in the left sidebar effectively concealing the presence of others.
Does that make sense?
@timabbott Yes, that makes sense. I think I can send a patch for that on it.
@timabbott so you want one scrollbar region for STREAMS and USERS instead of two separate scrollbar regions, correct?
@aashutoshrathi any update?
Hello @rmutalik, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.
You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.
Thanks for your contributions, and hope to see you again soon!
Welcome to Zulip, @prajneya! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
- Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
- Unwatch this repository, so that you don't get 100 emails a day.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
@timabbott
To clear things up, we currently have two separate scrollable sections of STREAMS and USERS.
We now basically need a section containing ALL the streams, and then ALL the users, and finally this entire section of STREAMS and USERS should be scrollable. Did I get this right?
Hello @prajneya, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.
You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.
Thanks for your contributions, and hope to see you again soon!
Hello @timabbott I tried reproducing this issue going in display settings then checking "Show user list on left sidebar in narrow windows" but users list is still in right side only!
Welcome to Zulip, @smitpatel24! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
- Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
- Unwatch this repository, so that you don't get 100 emails a day.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
Hello @tushar3105, it looks like we've already sent you a collaboration invite at https://github.com/zulip/zulip/invitations, but you haven't accepted it yet!
Please accept the invite and try to claim this issue again afterwards. We look forward to your contributions!
Hello @tushar3105, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.
We look forward to your valuable contributions!
I wanted to work on this issue but couldn't reproduce. Filed #17247 describing the issue I'm facing.
