zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

streams: Handle adding/removing stream events.

Open Abhirup-99 opened this issue 4 years ago • 10 comments

Fixes #816

Abhirup-99 avatar Dec 15 '20 19:12 Abhirup-99

@neiljp Sorry, the pr became a bit longer than I had anticipated it to be. This happened because of the addition of the tests, the incoming events from add_stream event is quite large so that primarily contributed to it, also handling of some race around conditions when the user is removed from a stream but is that stream is on view. I disabled some of the keypress events when that condition occurs. Any other thoughts/suggestions would be helpful.

Abhirup-99 avatar Dec 17 '20 01:12 Abhirup-99

@zulipbot add "PR needs review"

Abhirup-99 avatar Jan 01 '21 12:01 Abhirup-99

@Abhirup-99 You replied to some points, but do you want to do some big refactoring first, or go for a simpler version? I know what I'd like to do for the refactoring, but we could get this fixed first.

neiljp avatar Jan 12 '21 00:01 neiljp

@zulipbot add "PR needs review".

Abhirup-99 avatar Jan 15 '21 17:01 Abhirup-99

@zulipbot remove "PR needs update"

Abhirup-99 avatar Feb 11 '21 23:02 Abhirup-99

@zulipbot add "PR needs review"

Abhirup-99 avatar Feb 18 '21 20:02 Abhirup-99

@zulipbot remove "PR needs update"

Abhirup-99 avatar Feb 18 '21 20:02 Abhirup-99

@zulipbot add "PR needs review" remove "PR awaiting update"

Abhirup-99 avatar Mar 12 '21 00:03 Abhirup-99

@zulipbot remove "PR awaiting update"

Abhirup-99 avatar Mar 12 '21 00:03 Abhirup-99

Heads up @Abhirup-99, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Aug 30 '21 23:08 zulipbot