zulip-terminal
zulip-terminal copied to clipboard
zulip
Disable cycling to stream and recipients while editing
It is not possible to edit stream name for stream messages, nor the recipient emails for private messages. Thus, we should disable cycling to these boxes when a user tries to edit the message.
Update (neiljp): This is fixed for stream messages now, and needs fixing for PMs only.
This has a bit of conflict with #675, so should be fixed as a follow-up
This is also evident in 64724949d9816cb452b3ef4d1d812af8cddbf1f8, i.e., the invalid stream name check can be bypassed currently.
@preetmishra What do you mean by the check can be bypassed? Can it bypassed with tab or an arrow key?
An arrow key, which I think is what we're aiming for in this issue?
On second thought, perhaps this should be filed as another issue. Thoughts?
I agree opened #779 This issue is about disabling focus completely while editing, because we do not have the move streams feature (which will require pop-ups anyway), hence trying to edit stream name makes no sense.
Now that #1161 (#870) is merged, this leaves the private messages part to do. Anyone interested may benefit from looking at the commits merged in those PRs to see the test/code changes involved.
@neiljp I would like to work on fixing the issue for PMs if nobody is working on it currently :)
