zulip-terminal
zulip-terminal copied to clipboard
zulip
Restrict sending messages to announcement streams
is_announcement_only flag is present in model.stream_data. The user should be notified ( in the footer ) if they don't have permissions to post to the stream.
The key behavior is likely to make it that the user gets notified before writing a long message and then being unable to send it. So avoid even opening the compose box in these circumstances, though with a message for explanation.
This issue could be followed up with investigating any limitation on initiating private messages if they are disabled in organization settings https://www.zulipchat.com/help/restrict-private-messages We may want to confirm this feature is final first, however.
I resumed working on this but I see that this is already fixed by https://github.com/zulip/zulip-terminal/pull/714 @neiljp Can we close this?
@imnitishng The motivation for this issue is to provide a warning before the message is sent (which is what #714 will do), so that a user doesn't write a long message only for it to fail to send as they cannot post there, as I described here: https://github.com/zulip/zulip-terminal/issues/682#issuecomment-642129332
Okay I get it. Essentially we have to avoid opening the compose box in the streams where users aren't allowed to post. I will start the work and send a PR ASAP.
@imnitishng has this issue been resolved or is it fine if I take it up?
Hello @mounilKshah, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.
We look forward to your valuable contributions!
As my PR #1146 has been approved, the issue which was earlier assigned to me #1095 is fixed. Hence, I am beginning work on this issue. I hope that's fine.
Hello @mounilKshah, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.
You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.
Thanks for your contributions, and hope to see you again soon!
Hello @mounilKshah, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.
You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.
Thanks for your contributions, and hope to see you again soon!
@Chan-Dong-Jun This issue cannot be claimed, as someone else is already working on it. Please see our contributor guide for advice on finding an issue to work on. Thanks!
@Chan-Dong-Jun I have removed myself as the assignee for this issue. You or anyone else is free to work on this