zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Handle read events from server

Open kaustubh-nair opened this issue 5 years ago • 6 comments

TODO:

  • [ ] Limit number of unread msgs that are stored to ~10k

kaustubh-nair avatar Mar 10 '20 23:03 kaustubh-nair

@kaustubh-nair I know this is WIP, but continuing this work would be helpful to reliably track unread counts, depending on how busy you are with other things right now.

neiljp avatar Mar 17 '20 20:03 neiljp

@neiljp I was just finishing up with the typeahead footer PR, I'll be working on this one now. Added some tests for set_counts in the PR referenced above.

kaustubh-nair avatar Mar 18 '20 09:03 kaustubh-nair

@neiljp Thanks for the review! I've dealt with handling appending of messages as well. I'm pretty sure the keyerror you came across was due to this, since set_count was being called while new messages was not added to the index. If you still come across the exception, let me know!

Last two commits can be squashed later; I've kept them separate for now.

kaustubh-nair avatar Apr 07 '20 13:04 kaustubh-nair

@kaustubh-nair I'm still getting tracebacks in this PR; I've not read through it again in detail though, so can't make further comments at this stage.

neiljp avatar May 09 '20 00:05 neiljp

Heads up @kaustubh-nair, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Jan 30 '21 20:01 zulipbot

@kaustubh-nair can I take this up if you are not planning to continue work on this?

mkp6781 avatar Apr 04 '21 09:04 mkp6781