zulip-terminal
zulip-terminal copied to clipboard
[WIP] - Make UsersView consistent with other Views (Streams/Topic)
- Make UsersView a
urwid.Frameand RightColumnView aurwid.Pileobject. This change would be helpful in future if we decide to add buddy PM toRightColumnViewas well. - Move initializing
UserSearchbarintoUsersView.__init__. This is the header of a listbox. - Move
update_user_listintoUsersView. Use a slightly different logic to set contents in Frame after we update the order. - Extract
build_user_viewfunction inRightColumnViewwhich builds the user button list and returns it. This is called fromusers_viewonce during initialization and subsequently fromupdate_user_listat 60-sec intervals. - An old conditional
reset_default_view_usersis now removed as we clearly distinguish between init call and subsequent list update calls. - Keypress logic has been introduced to
UsersView. This mimicsStreamsView.keypress. SEARCH_PEOPLE AND GO_BACK are handled here. - The updating call from
model.pyat 60-second intervals has been modified.
Heads up @sumanthvrao, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.