Add/modify specific test(s) to expect a Divider may be in the stream list

[neiljp]

After adding pinned-messages separated by a urwid.Divider(), a few bugs appeared; the Divider is masquerading as a StreamButton, but that should be taken into account, and ideally the tests should have failed when I added the Divider. Based on that, we need more/modified tests for this.

[neiljp]

This would be a good issue if you either know tests/pytest, or want to learn it - we would prefer code to have tests in PRs if possible, so this issue starts from the other side and would likely involve just test additions/changes.

[devkant]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @devkant! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[devkant]

@neiljp I am learning pytest. Do I need to recreate the traceback ?

[neiljp]

@devkant I would suggest reading existing tests which examine/use the stream list.

It was some time ago, but I believe my intent with this issue was to explore why adding the Divider initially just appeared to work, but later bugs showed up since of course it was not actually a StreamButton and did not have all the same attributes. So, this could be about ensuring that the Divider (as well as other elements) have the expected properties, ie. at least for Divider the faked stream_name and stream_id attributes in view.py, in tests which expect to use those attributes on the elements.

[zulipbot]

Hello @devkant, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[devkant]

@zulipbot I am still working on it

[devkant]

@zulipbot claim

[zulipbot]

Hello @devkant, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[devkant]

@zulipbot claim

[zulipbot]

Hello @devkant, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[zulipbot]

Hello @devkant, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[parthi-siva]

Hi, @neiljp is this a still prevalent issue. Can I work on this

[kaxada]

@zulipbot claim

[iihimanshuu]

i wish to join this issue