zulip-terminal
zulip-terminal copied to clipboard
Fix #1506 : Improve handling of narrows (views) with no messages
What does this PR do, and why?
This PR improves handling of narrows with no messages by implementing a placeholder component
External discussion & connections
- [ ] Discussed in #zulip-terminal in
topic - [ x] Fully fixes #1506
- [ ] Partially fixes issue #
- [ ] Builds upon previous unmerged work in PR #
- [ ] Is a follow-up to work in PR #
- [ ] Requires merge of PR #
- [ ] Merge will enable work on #
How did you test this?
- [ ] Manually - Behavioral changes
- [ x] Manually - Visual changes
- [ ] Adapting existing automated tests
- [ ] Adding automated tests for new behavior (or missing tests)
- [ ] Existing automated tests should already cover this (only a refactor of tested code)
Self-review checklist for each commit
- [ ] It is a minimal coherent idea
- [ ] It has a commit summary following the documented style (title & body)
- [ ] It has a commit summary describing the motivation and reasoning for the change
- [ x] It individually passes linting and tests
- [ ] It contains test additions for any new behavior
- [x ] It flows clearly from a previous branch commit, and/or prepares for the next commit
Visual changes
@Niloth-p Do you have the bandwidth to give some thoughts on this, compared to your approach in #1543 ?