zulip
Add support for TODO Widget on ZT
What does this PR do, and why?
Adds support for TODO Widget
External discussion & connections
- [x] Discussed in #zulip-terminal in
topic - [ ] Fully fixes #
- [x] Partially fixes issue #986
- [ ] Builds upon previous unmerged work in PR #
- [ ] Is a follow-up to work in PR #
- [ ] Requires merge of PR #
- [ ] Merge will enable work on #
How did you test this?
- [x] Manually - Behavioral changes
- [x] Manually - Visual changes
- [x] Adapting existing automated tests
- [x] Adding automated tests for new behavior (or missing tests)
- [ ] Existing automated tests should already cover this (only a refactor of tested code)
Self-review checklist for each commit
- [x] It is a minimal coherent idea
- [x] It has a commit summary following the documented style (title & body)
- [x] It has a commit summary describing the motivation and reasoning for the change
- [x] It individually passes linting and tests
- [x] It contains test additions for any new behavior
- [x] It flows clearly from a previous branch commit, and/or prepares for the next commit
Visual changes
| Before | After | Webapp |
|---|---|---|
@neiljp Thanks for the feedback! I've updated the PR to handle the Submessage event, so ZT reflects updates in real-time without needing a refresh.
Thanks for pointing out the issue with the title not updating - it's fixed now! 👍
Added tests for both.
@rsashank We may need some followups on widget messages, such as limiting direct editing? I'm not sure what else may be necessary at this point.
@neiljp Thanks for the feedback! Updated this PR 👍
We may need some followups on widget messages, such as limiting direct editing? I'm not sure what else may be necessary at this point.
Isn't editing on widget messages already restricted? I could be mistaken, but I can't seem to edit.
@rsashank Thanks for the update; this looks good to go now - the remaining elements can be fine-tuned later :tada:
@rsashank You should be able to confirm using git range-commit, but I only updated the commit text slightly before pushing back here.
I've started #zulip-terminal>Widget followup work to discuss what seem to be the outstanding points after this work.