zulip-terminal
zulip-terminal copied to clipboard
Support (un)resolving topics
What does this PR do, and why?
This PR adds support for (un)resolving topics in ZT via TopicInfoView popup menu when topic is highlighted in left_stream_bar and i key is pressed to toggle topic settings.
Changes with respect to completion candidate PR:
-
Changes to tests
-
Dropped the first commit
External discussion & connections
- [x] Discussed in #zulip-terminal in
Support (un)resolving topics #T1235 (fix #T1075) - [x] Fully fixes #1075
- [ ] Partially fixes issue #
- [x] Builds upon previous unmerged work in PR #1235
- [ ] Is a follow-up to work in PR #
- [ ] Requires merge of PR #
- [ ] Merge will enable work on #
How did you test this?
- [x] Manually - Behavioral changes
- [x] Manually - Visual changes
- [x] Adapting existing automated tests
- [x] Adding automated tests for new behavior (or missing tests)
- [x] Existing automated tests should already cover this (only a refactor of tested code)
Self-review checklist for each commit
- [x] It is a minimal coherent idea
- [x] It has a commit summary following the documented style (title & body)
- [x] It has a commit summary describing the motivation and reasoning for the change
- [x] It individually passes linting and tests
- [x] It contains test additions for any new behavior
- [x] It flows clearly from a previous branch commit, and/or prepares for the next commit
Visual changes
@neiljp Thanks for the feedback!
Updated this PR :)