zulip-terminal
zulip-terminal copied to clipboard
External hotkey commands: tagging, linting and checking sync
What does this PR do, and why?
- Identify external hotkey commands with a suffix (readline shortcuts and terminal shortcuts)
- Lint for the usage of external commands in the codebase. They're not intended for direct use or modification.
- Check sync of readline shortcuts with urwid_readline's keymap.
External discussion & connections
- [ ] Discussed in #zulip-terminal in
topic - [ ] Fully fixes #
- [ ] Partially fixes issue #
- [ ] Builds upon previous unmerged work in PR #
- [ ] Is a follow-up to work in PR #1494
- [ ] Requires merge of PR #
- [ ] Merge will enable work on #
How did you test this?
- [x] Manually - Behavioral changes
- [ ] Manually - Visual changes
- [ ] Adapting existing automated tests
- [ ] Adding automated tests for new behavior (or missing tests)
- [ ] Existing automated tests should already cover this (only a refactor of tested code)
Self-review checklist for each commit
- [x] It is a minimal coherent idea
- [x] It has a commit summary following the documented style (title & body)
- [x] It has a commit summary describing the motivation and reasoning for the change
- [x] It individually passes linting and tests
- [ ] It contains test additions for any new behavior
- [x] It flows clearly from a previous branch commit, and/or prepares for the next commit
Visual changes
Our shortcuts missing in Readline's keymap:
On successful linting:
Linting errors: