zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Published 20 hours ago • verified publisher icon zulip

buttons/messages/views: Add support for copying code snippets.

Open yuktasarode opened this issue 2 years ago • 4 comments

What does this PR do? This PR aims to add support for copying code snippets and is based off on the work done by @kingjuno and @neiljp in the PR #1134. This PR mainly fixes the tests and linting issues and bring the PR to a merge-able state.

Tested?

  • [x] Manually
  • [x] Existing tests (adapted, if necessary)
  • [ ] New tests added (for any new behavior)
  • [x] Passed linting & tests (each commit)

This may fix the core elements of #1123.

yuktasarode avatar Mar 24 '23 10:03 yuktasarode

@yuktasarode Is this ready for review? If so, please change the labels as per my message in the GSoC 2023 topic in zulip-terminal (ie. remove needing update and add needs review).

neiljp avatar Apr 04 '23 20:04 neiljp

@zulipbot add "PR needs review"

yuktasarode avatar Apr 06 '23 07:04 yuktasarode

@zulipbot remove "PR awaiting update"

yuktasarode avatar Apr 06 '23 07:04 yuktasarode

@yuktasarode Could you please rebase this after the recent changes we had in main, and further explore how you might simplify and initialize the snippet button like we do with the MessageLinkButton? (given my comment above)

You're welcome to take up another issue also, of course :+1:

neiljp avatar Apr 08 '23 23:04 neiljp