zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Published 20 hours ago • verified publisher icon zulip

hotkeys: Add linting for hotkeys.

Open srdeotarse opened this issue 3 years ago • 3 comments

Currently, there is no linting for hotkeys.

For e.g. if help_text in keys.py ends with ., ./tools/generate_hotkeys.py updates help_text without linting it as key description in help menu doesn't contain .

srdeotarse avatar Apr 19 '22 13:04 srdeotarse

My original thought for this was:

  • Ensure that commits/PRs have the file and hotkey.py in sync via running a script, via a test in CI
  • More minorly, we could lint for the styles we use in the description, in a few different ways, or possibly other hotkey aspects (eg. possibly overlapping keys, if we have enough information)
  • generate_hotkeys.py could be added to make fix, since it automatically fixes the code

Removed the label as this is not a PR :)

neiljp avatar Apr 19 '22 23:04 neiljp

Hello @zulip/server-hotkeys members, this issue was labeled with the "area: hotkeys" label, so you may want to check it out!

zulipbot avatar Apr 19 '22 23:04 zulipbot

@srdeotarse You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

zulipbot avatar May 26 '22 01:05 zulipbot