homescreen_icon: Change 'globe' to 'list'

[dootMaster]

The current all-messages icon on mobile is a globe:

which doesn't match web Zulip's icon:

We're swapping it to the list icon for parity between mobile and web:

Fixes: #5303

[dootMaster]

@gnprice Sorry about that, I've pushed a new commit that should work now, although I don't know how to encapsulate the transform/scale prop into the function definition in Icons.js. I can make a wrapper component for the icon, but I'm not sure if that's what you were hinting at.

[gnprice]

Thanks for the revision. This pair of issues is still present: https://github.com/zulip/zulip-mobile/pull/5532#discussion_r1015888292

The quickest way to see them is to use git checkout main~ (if main is your branch where you're developing the changes). Then

• the app will crash when you run it, and print an error message to the terminal where you're running react-native start.
• tools/test flow will show two type errors. One is the cause of that crash, and both should be fixed.

although I don't know how to encapsulate the transform/scale prop into the function definition in Icons.js. I can make a wrapper component for the icon, but I'm not sure if that's what you were hinting at.

OK. Maybe the best approach there, then, is that when the PR is otherwise ready to merge, I'll add a commit on top that demonstrates the structure I have in mind, and merge with that.

[dootMaster]

@gnprice

The previous commit should be fixed now. 🤦‍♂️

[dootMaster]

@alya @gnprice is there anything else keeping this from being merged?