zulip-flutter
zulip-flutter copied to clipboard
ui: Adjust star icon position in message list
This pull request addresses issue #616, where the star icon appeared too high relative to the message text in the message list. The issue was resolved by adjusting the position of the star icon so that its "shoulders" align with the x-height of the first line of text, ensuring better visual alignment with the message content. I added padding to adjust the position of the star icon so that its "shoulders" are aligned with the x-height of the first line of text. This ensures better visual alignment with the message content. Also, its an update for this pull request #625
before
after
Fixes: #616 @sm-sayedi @gnprice
Thanks for the changes @Syrineladeb02. I suggest you read the commit messages guideline again on how to write commit messages and apply it before this is reviewed by the maintainers.
Also, there is no need to close a PR and open a new one for the same issue. You can fix the existing one by applying the methods mentioned in Fixing commits. 🙂
Thanks for the feedback, @sm-sayedi ! I'll revise the commit message and update the pull request accordingly.
@Syrineladeb02 Thanks for the contribution! Do you think you'll come back to this PR and address the feedback above?
Closing this PR, as the issue was resolved in #762. Thanks again @Syrineladeb02 for your work on this.