zulip-flutter icon indicating copy to clipboard operation
zulip-flutter copied to clipboard

Published 20 hours ago • verified publisher icon zulip

backoff: reset on successful event poll

Open chrisirhc opened this issue 1 year ago • 4 comments

Fixes: #554

chrisirhc avatar Mar 13 '24 04:03 chrisirhc

I've just edited the issue description to reference the issue it looks like this is about. Please correct it if it's wrong, but if it's right, please add a "Fixes" line to the relevant commit message too, once it's ready to be a not-draft. 🙂

chrisbobbe avatar Mar 26 '24 18:03 chrisbobbe

Ah yes, I created this but forgot about it. I saw a different way of approaching this by reseting the reference to backoffMachine as null instead of maintaining this reset state over at: https://github.com/zulip/zulip-flutter/blob/79a7384b5c8ad616f9bbd3874f8828736c279538/lib/model/store.dart#L633-L644

I could've gone down that approach as well, to keep the codebase consistent. Let me know if there's an opinion on this.

chrisirhc avatar Mar 27 '24 01:03 chrisirhc

Gentle bump to @chrisirhc to see if you're still interested in working on this. 🙂

chrisbobbe avatar May 22 '24 23:05 chrisbobbe

I'll likely get back to this in a few weeks. Based on the review comment, the change may end up being smaller/straightforward. So if anyone else wants to go ahead and do it before then, I won't be opposed. 🙂

chrisirhc avatar May 23 '24 00:05 chrisirhc

We ended up implementing the approach from https://github.com/zulip/zulip-flutter/pull/564#issuecomment-2021780297, as #871. Thanks again @chrisirhc!

gnprice avatar Aug 10 '24 00:08 gnprice