zulip-flutter icon indicating copy to clipboard operation
zulip-flutter copied to clipboard

Published 20 hours ago • verified publisher icon zulip

emoji: Generate popular candidates using names from server data

Open chrisbobbe opened this issue 6 months ago • 2 comments

The server change in zulip/zulip#34177, renaming :smile: to :slight_smile:, broke the corresponding reaction button in the message action sheet. We've been sending the add/remove-reaction request with the old name 'smile', which modern servers reject.

To fix, take the popular emoji names from ServerEmojiData, so that we'll use the correct name on servers before and after the change.

API-design discussion: https://chat.zulip.org/#narrow/channel/378-api-design/topic/.23F1495.20smile.2Fslight_smile.20change.20broke.20reaction.20button/near/2170354

Fixes: #1495

chrisbobbe avatar May 08 '25 20:05 chrisbobbe

Thanks for the review! Revision pushed.

chrisbobbe avatar May 16 '25 00:05 chrisbobbe

Looks good to me. Thanks! Marking this for Greg's review.

PIG208 avatar May 16 '25 01:05 PIG208

Thanks for the review! Revision pushed.

chrisbobbe avatar May 20 '25 23:05 chrisbobbe