Auto-reload behavior when connected to an invalid organization is buggy

[timabbott]

You can easily reproduce this as follows:

• Connect to an unavailable organization (e.g. localhost:10000, or localhost:9991 with no development server running).
• Try to go to the settings UI
• After a few seconds, you'll be navigated back to the unavailable organization's page, as part of the app's auto-reconnect retry behavior.

What we should fix:

• The auto-retry behavior shouldn't move the focus to the tab at all; it should just reload in the background. I don't see any situation where we'd want that navigation/focus change to happen; it's probably just code in a common code path with adding a new organization that's in the wrong place (or something).
• We probably aren't doing a reasonable exponential backoff for these retries. See https://chat.zulip.org/#narrow/stream/92-learning/topic/exponential.20backoff.20--.20with.20jitter/near/818761 for discussion on how this sort of backoff should be done.

[manavmehta]

If the organisation doesn't exist then it shouldn't get added in the first place. I am not sure how anyone would be able to add an unavailable organisation. @timabbott

[adityamudgil2505]

When I connect to localhost:10000 it instantly gives me an error. @timabbott Can you elaborate on what we are trying to solve?

[Somtozech]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @Somtozech! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[Somtozech]

@zulipbot claim

[zulipbot]

Hello @Somtozech, it looks like we've already sent you a collaboration invite at https://github.com/zulip/zulip-desktop/invitations, but you haven't accepted it yet!

Please accept the invite and try to claim this issue again afterwards. We look forward to your contributions!

[Somtozech]

@timabbott am trying to claim the issue. When I try to accept the invitation I get the error Sorry, we couldn't find that repository invitation. It is possible that the invitation was revoked or that you are not logged into the invited account. A screenshot is attached

[PawBud]

I would love to work on this bug, but I am not really able to reproduce it. Am I doing something wrong?

Version: v5.4.1-beta, (this is NOT the development version). OS:- Ubuntu 20.04 LTS (Focal Fossa)

[timabbott]

That reproduction attempt doesn't look right -- you need to connect to multiple organizations successfully (say chat.zulip.org and your development server), and then shut down your development server and try starting the app.

[Vansh5632]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @Vansh5632! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[Vansh5632]

@zulipbot unclaim

[timabbott]

Closing as we suspect we fixed this annoying symptom long ago.