zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Fixed:Broken image icon in left sidebar and typo in classname #630

Open Nikhil-Vats opened this issue 6 years ago • 5 comments

What's this PR do? The initial letter of Organistaion's name is shown instead of broken image when the app starts and typing mistake in main.js file in classname is fixed.

You have tested this PR on:

  • [x] Windows
  • [x] Linux/Ubuntu
  • [ ] macOS Fixes #562

Nikhil-Vats avatar Feb 08 '19 13:02 Nikhil-Vats

I accidentally messed up the previous PR, so reopened again. Sorry for the inconvenience caused.

Nikhil-Vats avatar Feb 08 '19 13:02 Nikhil-Vats

This needs to be referenced to the appropriate issue number. I accidentally assigned myself that issue, because i did not see any open PRs for that issue.

vsvipul avatar Feb 09 '19 13:02 vsvipul

@akashnimare Can you review this PR please? :D

Nikhil-Vats avatar Mar 29 '19 05:03 Nikhil-Vats

Heads up @Nikhil-Vats, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Aug 17 '19 14:08 zulipbot

@Nikhil-Vats hey, can you fix the merge conflicts please and maybe upload a gif to show the fix?

akashnimare avatar May 19 '20 15:05 akashnimare