zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Tray icon should probably include Zulip logo even with unread messages

Open timabbott opened this issue 8 years ago • 7 comments
trafficstars

I think it could be worth modifying this icon to look more like the Zulip favicons, with the unread count in the corner over a clear Zulip logo:

image

timabbott avatar Aug 01 '17 21:08 timabbott

There are two methods to achieve this -

  • a) Re-use all the favicons from https://github.com/zulip/zulip/tree/master/static/images/favicon and depending upon the unread counts use them in iconPath.
  • b) Currently we create the canvas using the unread counts which look like this -

image

Re-using the code from this PR we can include the Zulip logo in the same canvas.

akashnimare avatar Jan 11 '18 20:01 akashnimare

One more thing to note here that the canvas image cannot be used a Icon for tray, so we will have to use nativeImage module provided by electron for sake of ease.

priyank-p avatar Jan 11 '18 21:01 priyank-p

@cPhost we do pass this canvas image in nativeImage module, see here.

akashnimare avatar Jan 11 '18 21:01 akashnimare

I think we can do the first method, i.e. Re-use all the favicons from depending on the number of unread messages. If that's ok, I would like to work on this.

abhigyank avatar Jan 22 '18 09:01 abhigyank

@abhigyank not really its not that simple ie considering diffrent icon size we have to consider for diffrent os's they look kind of blurry, we are currenly trying to solve it.

priyank-p avatar Jan 22 '18 12:01 priyank-p

WIP in - https://github.com/zulip/zulip-electron/pull/385 and tray-icon. We are considering both the options but as Priyank said it's not kind of tricky to make the icon look good on all the platforms.

akashnimare avatar Jan 22 '18 13:01 akashnimare

If this issue is still open,please assign it to me

karthiknadar1204 avatar Apr 08 '23 15:04 karthiknadar1204