zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Replace Appveyor by GitHub Actions for Windows

Open yaminijha1 opened this issue 1 year ago • 3 comments

What's this PR do? Fixes #1070

This PR remove the Appveyor CI workflow and adds GitHub Actions on Windows build

yaminijha1 avatar Jan 10 '24 15:01 yaminijha1

@yaminijha1 Can you squash the second commit into the first? Thanks!

shubham-padia avatar Jun 19 '25 05:06 shubham-padia

Hi ~shubham-padia, This PR #1350 now fixes #1070 and incorporates all your suggestions:

Updated the Node.js version to lts/* Switched to setup-node@v4 Squashed the commits into one, as requested

Please let me know if any further changes are needed.

yaminijha1 avatar Jun 20 '25 03:06 yaminijha1

@timabbott this should be ready for integration review

shubham-padia avatar Jun 20 '25 07:06 shubham-padia

@zulipbot @timabbott this PR #1350 now fixes #1070 without any conflict without any conflict.

yaminijha1 avatar Aug 07 '25 17:08 yaminijha1

  • If we’re running more or less the same steps on both platforms, this should use a matrix.

  • The extra node --version and npm --version are not needed because GitHub already includes these in the log under Run actions/setup-node@v4 → Environment details. python --version is not needed because we do not use Python.

  • The Appveyor badge needs to be removed from README.md.

andersk avatar Nov 16 '25 07:11 andersk

Heads up @yaminijha1, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Nov 19 '25 23:11 zulipbot