zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Show sidebar on navigating to Settings page

Open tarun8718 opened this issue 4 years ago • 3 comments

Signed-off-by: tarun8718 [email protected]

What's this PR do? Shows Sidebar(if disabled) on navigating to the settings page(for users with single-organizations). Fixes: #1077
sidebar

You have tested this PR on:

  • [ ] Windows
  • [X] Linux/Ubuntu
  • [ ] macOS

tarun8718 avatar Mar 02 '21 05:03 tarun8718

@andersk could you please review this?

tarun8718 avatar Mar 10 '21 10:03 tarun8718

Hey @tarun8718 Thanks for this PR. One question I have in mind is why are we adding this piece of code for accounts with only one organization, where if you have multiple, you'll probably still face the same issue? Also, I'd recommend writing a clearer and descriptive commit message.

manavmehta avatar Oct 09 '21 18:10 manavmehta

@tarun8718 Let me know if you need a hand or if we should continue the work as you've already done the most.

manavmehta avatar Oct 21 '21 15:10 manavmehta