zulip-archive
zulip-archive copied to clipboard
404 on certain pages even when html view exists
ex. https://juliacommunity.github.io/zulip-archive/stream/274208-helpdesk-(published)/topic/.60eachline(.3A.3AIOBuffer).60.20for.20other.20delimiters.html (source at https://github.com/JuliaCommunity/zulip-archive/blob/master/274208-helpdesk-(published)/topic/.60eachline(.3A.3AIOBuffer).60.20for.20other.20delimiters.html)
I speculate this has something to do with the leading . (generated in this case by the post-URLencoding % -> . replacement). Does Jekyll have some special logic for this that is tripping things up?
It's been pointed out to me that the relevant logic lives in https://github.com/zulip/zulip-archive/blob/bcd29a173500de778e70a304fc40cdffaec78803/lib/url.py#L62-L64. Is there any benefit to using this solution over a known 3rd-party library like https://github.com/un33k/python-slugify?
I'm not sure -- I think @showell or @rht might have thought more about the URL-encoding for zulip-archive than I have?
I think part of the complexity here is that this wants to agree with the URL-encoding methods used by the Zulip webapp.
I think this can be closed as we don't use jekyll anymore.
I think this can be closed as we don't use jekyll anymore.
@rht perhaps you could close this issue if you agree? Thanks!
I don't have admin right to close the issue, but I agree with @refeed. The issue is fixed by https://github.com/zulip/zulip-archive/commit/78da21b67e73d2ca7c42a7dfee9547b4645a2836.
Though it's because of the URL encoding, not specifically Jekyll.