zulip-android-legacy icon indicating copy to clipboard operation
zulip-android-legacy copied to clipboard

Restore narrow and scroll after theme switch.

Open jainkuniya opened this issue 8 years ago • 5 comments
trafficstars

Fix:#406

Summary of changes

Now narrow and scroll is restored after switching theme.

Screenshots Switching theme in homeView ezgif com-video-to-gif 2

Switching theme in narrowedView ezgif com-video-to-gif 3

Switching theme in narrowedView and coming back to home ezgif com-video-to-gif 4

Please make sure these boxes are checked before submitting your pull request - thanks! Guide

  • [x] Code is formatted.

  • [x] Run the lint tests with ./gradlew lintDebug and make sure BUILD is SUCCESSFUL

  • [x] If new feature is implemeted then it is compatible with Night theme too.

  • [x] Commit messages are well-written.

jainkuniya avatar Feb 20 '17 19:02 jainkuniya

resolved conflicts

jainkuniya avatar Mar 10 '17 11:03 jainkuniya

@vishwesh3 thanks for working on this! 👍 Faced one issue: When I tried the changes, on switching the theme, the load position of message is not maintained in the narrow. Heres a short video https://drive.google.com/open?id=0B4jK5QX65b0ZV2xzTFR2d2pyYjQ

Sam1301 avatar Mar 27 '17 05:03 Sam1301

Updated

ezgif com-video-to-gif 14

jainkuniya avatar Mar 27 '17 12:03 jainkuniya

@vishwesh3 this looks great! 👍 Though I am still facing the load position bug on switching theme for a stream. Here's a short video https://drive.google.com/open?id=0B4jK5QX65b0ZbzZoR1BvVjd1M1E Also noticed a typo in the last commit :).

Sam1301 avatar Mar 28 '17 06:03 Sam1301

Heads up @vishwesh3, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Aug 09 '17 04:08 zulipbot